Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserializing of inline links back to MDX result in improper JSX #1169

Closed
johno opened this issue Jul 22, 2020 · 2 comments
Closed

Reserializing of inline links back to MDX result in improper JSX #1169

johno opened this issue Jul 22, 2020 · 2 comments
Labels
💪 phase/solved Post is done 🐛 type/bug This is a problem 💎 v2 Issues related to v2
Milestone
v2

Comments

@johno
Copy link
Member

johno commented Jul 22, 2020

Input

https://styled-components.com

AST

            {
              "type": "link",
              "title": null,
              "url": "https://styled-components.com",
              "children": [
                {
                  "type": "text",
                  "value": "https://styled-components.com",
                  "position": {
                    "start": {
                      "line": 79,
                      "column": 1,
                      "offset": 1913
                    },
                    "end": {
                      "line": 79,
                      "column": 30,
                      "offset": 1942
                    },
                    "indent": []
                  }
                }
              ],

Actual output (back in MDX form)

<https://styled-components.com/>

Expected output

https://styled-components.com

or

[https://styled-components.com](https://styled-components.com)
@johno johno added 🐛 type/bug This is a problem 🙆 yes/confirmed This is confirmed and ready to be worked on 💎 v2 Issues related to v2 labels Jul 22, 2020
@johno johno mentioned this issue Jul 22, 2020
Closed
25 tasks
johno added a commit that referenced this issue Jul 22, 2020
@johno
Add failing test for MDX v2 inline link serialization
dd074be 
Fixes #1169
@johno johno mentioned this issue Jul 22, 2020
Merged
johno added a commit that referenced this issue Jul 22, 2020
@johno
Implement inline link serialization that doesn't wrap them in angle
1cc3bb1 
brackets

Fixes #1169
johno added a commit that referenced this issue Jul 22, 2020
@johno
Implement inline link serialization that doesn't wrap them in angle
97b33b3 
brackets

Fixes #1169
johno added a commit that referenced this issue Jul 22, 2020
@johno
Implement inline link serialization that doesn't wrap them in angle
732ca38 
brackets

Fixes #1169
johno added a commit that referenced this issue Jul 22, 2020
@johno
Implement inline link serialization that doesn't wrap them in angle
001e6a6 
brackets

Fixes #1169
johno added a commit that referenced this issue Jul 22, 2020
@johno
Implement inline link serialization that doesn't wrap them in angle (#…
649dbd8 
…1171)

brackets

Fixes #1169
@wooorm
Copy link
Member

wooorm commented Jul 22, 2020

@johno I think this can be closed?

@johno
Copy link
Member Author

johno commented Jul 22, 2020

Ah, yep!

@johno johno closed this as completed Jul 22, 2020
@johno johno added this to the v2 milestone Jul 22, 2020
@wooorm wooorm added ⛵️ status/released and removed 🙆 yes/confirmed This is confirmed and ready to be worked on labels Jul 23, 2020
@wooorm wooorm added the 💪 phase/solved Post is done label Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💪 phase/solved Post is done 🐛 type/bug This is a problem 💎 v2 Issues related to v2
Milestone
v2
Development

No branches or pull requests
2 participants
@wooorm @johno