Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation to use classic runtime #1307

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Add annotation to use classic runtime #1307

merged 1 commit into from
Oct 20, 2020

Conversation

ykzts
Copy link
Contributor

@ykzts ykzts commented Oct 20, 2020

React v17 introduces a new syntax, JSX Runtime. MDX uses the traditional React.createElement, so if you mix it with the JSX Runtime, it will fail to build. This Pull Request adds an annotation that allows the classic runtime to be used, which is a temporary solution.

ref https://babeljs.io/docs/en/babel-plugin-transform-react-jsx

@vercel
Copy link

vercel bot commented Oct 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/axi0qcte1
✅ Preview: https://mdx-git-jsx-runtime-clasic.mdx.vercel.app

@vercel vercel bot temporarily deployed to Preview October 20, 2020 21:35 Inactive
Copy link
Member

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johno johno merged commit ea6a41c into mdx-js:master Oct 20, 2020
@ykzts ykzts deleted the jsx-runtime-clasic branch October 20, 2020 21:44
wooorm pushed a commit that referenced this pull request Dec 17, 2020
wooorm pushed a commit that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants