Add isMDXComponent static class prop to generated classes
#369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the behavior discussed in #368
|
This pull request is automatically deployed with Now. |
|
I'm sorry for all the commit spam, just wanted to try how the GitHub editor experience was 😝 |
johno
changed the title
isMDXComponent static class prop to generated classesisMDXComponent static class prop to generated classes
|
Are there any blockers for this PR? I was wondering if we could have it merged. Many thanks. |
|
Maybe checking import ChangeLog from './changelog.mdx'
ChangeLog.displayName === 'MDXContent'
// or
ChangeLog.displayName.includes('MDX') |
|
This sadly didn't work for uglified builds where class names get changed. |
johno
reviewed
Feb 14, 2019
Are you sure you didn't accidentally try And thanks for your work on this PR, I'm just curious. 😄 |
Co-Authored-By: hugmanrique <hugmanrique@users.noreply.github.com>
Co-Authored-By: hugmanrique <hugmanrique@users.noreply.github.com>
|
Thanks @hugmanrique! |
johno
pushed a commit
that referenced
this pull request
Feb 18, 2019
* Add `isMDXElement` static class prop to generated classes Adds the behavior discussed in #368 * s/element/component * Add isMDXComponent test * Define static class prop the old way * Fix prettier error * Revert new line removal * Fix prettier error * Add function to snapshot test * Missed a ; * Change isMDXComponent type to bool Co-Authored-By: hugmanrique <hugmanrique@users.noreply.github.com> * Apply suggestions from code review Co-Authored-By: hugmanrique <hugmanrique@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently no way to detect whether a class was generated by
@mdx-js/mdx, and this PR adds aisMDXComponent()static class property to check whether the exported component was generated by mdx.Closes #368