Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add English (gb) translation #27

Merged
merged 235 commits into from
Jun 29, 2019
Merged

Add English (gb) translation #27

merged 235 commits into from
Jun 29, 2019

Conversation

mdziekon
Copy link
Owner

@mdziekon mdziekon commented Feb 20, 2019

Closes #19

TODO:

  • Reformat all polish language files (code style cleanups).
    • New line ending of each file.
    • Trailing whitespaces removal.
    • Weird formatting (eg. values alignment) removal.
    • Language mistakes fixes.
    • Task reward strings are now dynamically generated instead of redundantly hardcoded.
  • Remove unused localisation texts from various files
  • Make ReCaptcha use default server's language (DEFAULT_LANG)
  • Translate all language files to English:
    • aboutpro.lang
    • activate.lang
    • admin.lang
    • alliance.lang
    • attackslist.lang
    • banned.lang
    • bannedUser.lang
    • buddy.lang
    • buildings.lang
    • changelog.lang
    • chat.lang
    • contact.lang
    • converter.lang
    • cookies.lang
    • declaration.lang
    • destroy_rockets.lang
    • email_change.lang
    • empire.lang
    • firstlogin.lang
    • fleet.lang
    • FleetMission_MissileAttack.lang
    • fleetshortcut.lang
    • galacticshop.lang
    • galaxy_ajax.lang
    • galaxy.lang
    • generate_sig.lang
    • infos.lang
    • jumpgate.lang
    • leftmenu.lang
    • login.lang
    • logout.lang
    • lostcode.lang
    • lostpassword.lang
    • merchant.lang
    • messages.lang
    • messageSystem.lang
    • months.lang
    • moon_sim.lang
    • morale_info.lang
    • notes.lang
    • officers.lang
    • overview.lang
    • phalanx.lang
    • polls.lang
    • profile.lang
    • readBattleReport.lang
    • records.lang
    • reftable.lang
    • reg_ajax.lang
    • reg_mainpage.lang
    • report.lang
    • resources.lang
    • rocket_simulator.lang
    • rules.lang
    • rules.definitions.default.lang
    • search.lang
    • settings.lang
    • sfbInfos.lang
    • simulator.lang
    • spyReport.lang
    • stat.lang
    • system.lang
    • tasks_infobox.lang
    • tasks.lang
    • tech.lang
    • texts.lang
    • topmenu.lang
    • worldElements.detailed.lang
    • admin/addMoon.lang
    • admin/alerts_filters.lang
    • admin/alerts.lang
    • admin/autogziplogs.lang
    • admin/autostatbuilder.lang
    • admin/banslist.lang
    • admin/banuser.lang
    • admin/bashDetector.lang
    • admin/browse_actionlogs.lang
    • admin/chatbrowser.lang
    • admin/cron_GarbageCollector.lang
    • admin/declarations_list.lang
    • admin/errorslist.lang
    • admin/FleetControl.lang
    • admin/iplog_addproxy.lang
    • admin/iplog.lang
    • admin/massmessage.lang
    • admin/messagelist.lang
    • admin/planets_resmanager.lang
    • admin/reduceban.lang
    • admin/reports_list.lang
    • admin/settings.lang
    • admin/SFBSettings.lang
    • admin/ship_calculations.lang
    • admin/telemetry.lang
    • admin/unbanuser.lang
    • admin/user_info.lang
    • admin/userdevscanner.lang
    • admin/userlist.lang
    • admin/users_techmanager.lang
  • Find and remove all "hardcoded" Polish texts. So far I'm aware of:
  • Set the default language to en
  • Add ability to switch the language per user
    • On the "main page" - login, registration, recovery pages
    • At server's installation (both for the installation script and as a server's default lang)
    • At registration
    • In-game (account settings)

Localisation by-products:

  • js/jsChronoApplet.js has been refactored to make it more performant (now it uses one WebAPI timer to handle all countdowns, instead of spawning separate timers for each countdown).
  • Cron scripts (eg. autostatbuilder.php) are a bit more secure when dealing with password-protected access (empty password is no longer accepted).
  • install script has been refactored - simplified branching, better modularisation.
  • Registration script has received a fix to correctly generate Multiverse selector & infoboxes (previously, it would render only the last defined Universe's info and selector option).

(end new line & removed trailing whitespaces)
@mdziekon mdziekon added the pr:work_in_progress All pull requests which are still in progress label Feb 20, 2019
@mdziekon mdziekon force-pushed the mdziekon/19/english-language branch 2 times, most recently from 41fcb1d to 0556fc9 Compare June 28, 2019 06:54
@mdziekon mdziekon force-pushed the mdziekon/19/english-language branch from 0556fc9 to 1fef949 Compare June 28, 2019 06:56
@mdziekon mdziekon force-pushed the mdziekon/19/english-language branch from 977e556 to cefdb72 Compare June 29, 2019 18:19
@mdziekon mdziekon changed the title WIP: Add English (gb) translation Add English (gb) translation Jun 29, 2019
@mdziekon mdziekon added pr:enhancement_request All pull requests related to enhancements proposals and removed pr:work_in_progress All pull requests which are still in progress labels Jun 29, 2019
@mdziekon mdziekon merged commit 343b6a6 into master Jun 29, 2019
@mdziekon mdziekon deleted the mdziekon/19/english-language branch July 6, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:enhancement_request All pull requests related to enhancements proposals
Projects
None yet
1 participant