Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port minor fixes to the codebase from PR #61 | Part 10 #74

Merged
merged 10 commits into from
Feb 19, 2020

Conversation

mdziekon
Copy link
Owner

@mdziekon mdziekon commented Feb 19, 2020

Part of #63

Changelog:

  • Generalise the code responsible for determining the Research Network info
  • Generalise the code responsible for handling & updating planets with Laboratory in Queue, when checking these planets to determine whether research is possible
  • Handle all planets with queued Lab at once instead of "one by one"
  • Fix a bug allowing to start research when more than one planet would have queued laboratory, and the last one (fetch-wise) would have the shortest completion time

@mdziekon mdziekon added the pr:enhancement_request All pull requests related to enhancements proposals label Feb 19, 2020
@mdziekon mdziekon added this to In progress in Basic modernisation via automation Feb 19, 2020
@mdziekon mdziekon changed the title WIP: Port minor fixes to the codebase from PR #61 | Part 9 Port minor fixes to the codebase from PR #61 | Part 9 Feb 19, 2020
@mdziekon mdziekon changed the title Port minor fixes to the codebase from PR #61 | Part 9 Port minor fixes to the codebase from PR #61 | Part 10 Feb 19, 2020
@mdziekon mdziekon marked this pull request as ready for review February 19, 2020 23:04
@mdziekon mdziekon merged commit cb8846d into master Feb 19, 2020
Basic modernisation automation moved this from In progress to Done Feb 19, 2020
@mdziekon mdziekon added the pr:bugfix All pull requests related to fixing bugs label Feb 23, 2020
@mdziekon mdziekon deleted the mdziekon/63/port-minor-modifications-part10 branch March 3, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix All pull requests related to fixing bugs pr:enhancement_request All pull requests related to enhancements proposals
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant