Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fleet missions' code | Part 03 | Galaxy debris update #94

Merged
merged 8 commits into from
Mar 29, 2020
Merged

Refactor fleet missions' code | Part 03 | Galaxy debris update #94

merged 8 commits into from
Mar 29, 2020

Conversation

mdziekon
Copy link
Owner

@mdziekon mdziekon commented Mar 29, 2020 •
edited

Summary:

Currently there are three places with galaxy entry debris update code duplicated. All of them should use a shared function to update the entry.

Changelog:

  • Extract galaxy debris update code into separate util functions
  • Use the new updating functions in attacks handling functions:
    • Regular attack
    • Group attack (ACS)
    • Moon destruction

Related issues or PRs:

@mdziekon mdziekon added the pr:enhancement_request All pull requests related to enhancements proposals label Mar 29, 2020
@mdziekon mdziekon added this to In progress in Basic modernisation via automation Mar 29, 2020
@mdziekon mdziekon marked this pull request as ready for review March 29, 2020 23:31
@mdziekon mdziekon merged commit e018064 into master Mar 29, 2020
Basic modernisation automation moved this from In progress to Done Mar 29, 2020
@mdziekon mdziekon mentioned this pull request Mar 29, 2020
Open
@mdziekon mdziekon changed the title Refactor fleet missions' code | Part 02 | Galaxy debris update Refactor fleet missions' code | Part 03 | Galaxy debris update Mar 31, 2020
@mdziekon mdziekon deleted the mdziekon/91/fleet-mission-attack-refactor-part03 branch April 2, 2020 22:04
@mdziekon mdziekon removed this from Done in Basic modernisation Apr 8, 2022
@mdziekon mdziekon added this to In progress in Flight Control refactor via automation Apr 8, 2022
@mdziekon mdziekon moved this from In progress to Done in Flight Control refactor Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:enhancement_request All pull requests related to enhancements proposals
Projects
Flight Control refactor
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mdziekon