Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Missing serving size on the nutrition label #2804

Open
6 tasks done
monksy opened this issue Dec 9, 2023 · 8 comments
Open
6 tasks done

[BUG] - Missing serving size on the nutrition label #2804

monksy opened this issue Dec 9, 2023 · 8 comments
Labels
bug: confirmed bug Something isn't working

Comments

@monksy
Copy link

monksy commented Dec 9, 2023

First Check

  • This is not a feature request.
  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the Mealie documentation, with the integrated search.
  • I already read the docs and didn't find an answer.
  • This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

The nutritional card on the recipe page does not state the recipe serving size that the nutrition reflects.

Steps to Reproduce

View a recipe, and the card does nto reflect the serving size.

Please provide relevant logs

https://www.fatkitchen.com/low-carb-challah-bread/

Contains a recipe json value in nutrition.servingSize

Mealie Version

Nightly

Deployment

Docker (Linux)

Additional Deployment Details

The template could be formated like this:

nutrition.servingSize out of recipeYield[0]

<v-card-title class="pt-2 pb-0">

@monksy monksy added bug Something isn't working triage labels Dec 9, 2023
@monksy monksy changed the title [BUG] - YOUR TITLE [BUG] - Missing serving size on the nutrition label Dec 9, 2023
@michael-genson
Copy link
Collaborator

Can you provide a screenshot of what you're seeing? I'm not sure what you're referring to with the nutrition label

@monksy
Copy link
Author

monksy commented Dec 12, 2023

image

Recipe brings in serving size in the json data.

The nutrition label needs to explain what that is based on (the serving size)

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 24, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
@monksy
Copy link
Author

monksy commented Jan 30, 2024

It's still an issue

@hay-kot
Copy link
Collaborator

hay-kot commented Mar 11, 2024

I don't understand why this is a bug. We display the servings that are scraped from the recipe on the recipe.

CleanShot 2024-03-11 at 08 26 19@2x

@monksy
Copy link
Author

monksy commented Mar 11, 2024

@hay-kot the nutrition facts that are showned below are those per the entire recipe or per serving?

Screenshot_20240311_103210

@hay-kot
Copy link
Collaborator

hay-kot commented Mar 11, 2024

If the information is scraped, we can't know AFAIK because each provider can choose how they provide that information.

You'd have to do some kind of verification.

If you want to specify a different measurement/size specifically for the nutrition, that would be a feature request and not a bug.

@monksy
Copy link
Author

monksy commented Mar 11, 2024

Some of the recipe JSON outs include a portion size field. I included an example of that in the first comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: confirmed bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants