Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: email password reset link directly from admin dashboard #3147

Conversation

Kuchenpirat
Copy link
Collaborator

@Kuchenpirat Kuchenpirat commented Feb 10, 2024

What type of PR is this?

  • feature

What this PR does / why we need it:

This adds the option to directly send an email with the password reset link to the email adress of the user.

Most users will propably find the "Forgot Password" field on the login screen themselves, but some not so tech savy will just call their e.g. family member that hosts mealie and aks them to fix it.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

  • This does currently not test whether email is enabled. But this does seem to be common for other buttons as well.
  • The token that is send per email is not the same as the one displayed in the dashboard, because the email function generates a new token. Both work.

Testing

Tested with the mailpit service. Mealie does generate the link a bit false (port 8080 instead of 3000) but if the user has email configured correctly, this sould not fail as it uses the normal forgot-password api endpoint.

@Kuchenpirat Kuchenpirat changed the title feat: email to user password reset in admin dashboard feat: email password reset link directly from admin dashboard Feb 12, 2024
@boc-the-git
Copy link
Collaborator

@Kuchenpirat any chance you can add before and after images please?

@boc-the-git
Copy link
Collaborator

The mail pit issue, does that relate just to the Dev container?

@Kuchenpirat
Copy link
Collaborator Author

The mail pit issue, does that relate just to the Dev container?

Yep, that is only mailpit. I just pushed another commit setting the BASE_URL in the taskfile which fixes that.

@Kuchenpirat
Copy link
Collaborator Author

Kuchenpirat commented Feb 13, 2024

Screenshots:

Before:
image

After:
image

Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@boc-the-git boc-the-git merged commit 30ec65f into mealie-recipes:mealie-next Feb 13, 2024
9 checks passed
@Kuchenpirat Kuchenpirat deleted the feat--send-reset-email-from-admin-dashboard branch February 13, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants