fix: Pydantic Serialization Issues #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
commented
Feb 11, 2024
| # if we're missing a label, but the food has a label, use that as the label | ||
| if (not self.label) and (self.food and self.food.label): | ||
| self.label = self.food.label | ||
| self.label_id = self.label.id | ||
|
|
||
| return self |
There was a problem hiding this comment.
Pydantic reassigns the instance for some reason, so yeah, we do actually have to return self here
hay-kot
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, it couldn't be that easy to upgrade, could it?
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
In certain instances, Pydantic will bypass its
__init__(mostly related to ORM). In a few instances we were overriding Pydantic's__init__to do some post-init validation. Thankfully, Pydantic V2 supports this out of the box with itsmodel_validatorwhen set tomode="after".I also noticed when adding recipes to the shopping list we were losing units for some reason. I'm not quite sure what happened, but somewhere we were relying on Pydantic choosing the correct sub-model (
IngredientUnitvsCreateIngredientUnit), and now it isn't anymore. So I fixed that by adding the id as an optional field so it always gets serialized when present.Which issue(s) this PR fixes:
(REQUIRED)
N/A
Special notes for your reviewer:
(fill-in or delete this section)
🙃
Testing
(fill-in or delete this section)
Manually