Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new OIDC TLS CA Certfile option #3496

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

cmintey
Copy link
Contributor

@cmintey cmintey commented Apr 19, 2024

What type of PR is this?

  • feature

What this PR does / why we need it:

Some users have their IdPs secured with a private certificate authority. Currently, TLS verification fails for those users. Similarly to LDAP, this PR adds an option to specify a path to a CA cert bundle to verify requests against.

Which issue(s) this PR fixes:

Closes #3489

Testing

Created a new image and the OP of the issue verified the changes worked

Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@boc-the-git boc-the-git merged commit 1a385e9 into mealie-recipes:mealie-next Apr 19, 2024
10 checks passed
@cmintey cmintey deleted the oidc-tls-certfile branch August 13, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - OIDC is not usable with private CAs
2 participants