-
-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show recipe tags on mobile view and meal plan #3864
feat: Show recipe tags on mobile view and meal plan #3864
Conversation
1a39602
to
e88d242
Compare
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
e88d242
to
47cb363
Compare
My initial thoughts here are how many tags should be displayed (you've capped at 2)? What if people don't want any tags displayed? Are there places other than the meal plan they should be displayed (from a skim it looks like you've only added it there)? I don't have good answers here, just dumping some thoughts. |
There is currently a place where the tags are shown like this - on the recipe search page when viewed on desktop (ut not mobile, this PR adds that). I capped at two tags because that was what was currently being used on the desktop view and thought it made sense to be consistent. See here:
There isn't a previous feature request. Should I still open one? |
It would be nice if this stuff could be configured in setting - e.g. show/hide tags, configure number of tags shown. But that's a larger change that effects other areas too and not something I'm currently comfortable with tackling. |
Do you know why that isn't displaying on mobile? From a quick look I couldn't see why.. Assuming it's unintentional (not specifically coded for), that could be a good change to add in here?
No stress, was just wondering if there was previous discussion.
Any chance you want to raise a feature request for that? |
Yeah, because on mobile it uses the
Good idea. I'll put something together later today hopefully. :) |
@michael-genson @Kuchenpirat , any concerns with this change? |
Yeah this looks fine to me, looks like we just never added tags to the mobile card view |
Thanks Marcus! |
Thank you so much for making my first contribution so pleasent! 😀 Will for sure be looking out for other things I can help improve. |
What type of PR is this?
What this PR does / why we need it:
This change makes it so that tags on a recipe will show in mobile view as well as on the meal plan for both mobile and desktop.
Meal plan - mobile
Meal plan - desktop
Which issue(s) this PR fixes:
N/A
Testing
Manual testing with example recipes. Created recipes with no tags, single tags and multiple (3) tags to ensure all show as expected.