Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

[bug] Dont use Cache #1008

Merged
merged 1 commit into from
Oct 31, 2015
Merged

[bug] Dont use Cache #1008

merged 1 commit into from
Oct 31, 2015

Conversation

codydaig
Copy link
Member

Having cache on the build is gibing us a false positive. As soon as I remove the cache, it will use the latest npm modules, and let us know when it's truly failing because of package dependencies.

I cloned the repo into a new directory and I'm getting the same mongo error locally as this PR is able to duplicate on the server.

@codydaig
Copy link
Member Author

This build will pass once #1009 gets merged in and I rebase.

@codydaig
Copy link
Member Author

@lirantal This actually removes the cache that you added to show us if a package updated and causes things to break in the project.

@ilanbiala
Copy link
Member

@codydaig do we still need this?

@codydaig
Copy link
Member Author

@ilanbiala I would still like this. It will allow us to see when updated dependencies are failing the build versus just using outdated dependences.

@ilanbiala
Copy link
Member

@codydaig when do we get outdated dependencies though? I haven't really seen it other than with Mongoose.

@codydaig
Copy link
Member Author

@ilanbiala Any time a package updates, it won't download the latest on Travis, it will use the cached version. This is just the first time that a package released a patch that broke our code.

@ilanbiala
Copy link
Member

@codydaig sent an email to Travis-CI, let's see if they have any plans to check against npm and see whether new versions are available before using the cache.

@lirantal
Copy link
Member

@codydaig Ok, though this should stop 0.4.2 from being release so let's move it to 0.5.0 milestone?

@codydaig
Copy link
Member Author

@ilanbiala IMO, regardless of what Travis' plans are, this should get merged in and if Travis releases support to check against npm versions, then we can readdress and add cache support back in.

@lirantal This is either a merge or don't merge. If we don't merge it then we should just close it out.

@ilanbiala
Copy link
Member

@codydaig right now Travis doesn't properly verify npm deps, so let's merge and I'll keep following up with them to see if they have plans to change it so we can cache.

codydaig added a commit that referenced this pull request Oct 31, 2015
bug(travis): Remove Cache from .travis.yml
@codydaig codydaig merged commit 4dc0f30 into meanjs:master Oct 31, 2015
@codydaig codydaig deleted the nocache branch October 31, 2015 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants