feat(gulp): test:server:watch task onlyChanged #1298
Conversation
|
Coverage remained the same at 70.615% when pulling efeacbb7e2eab3efe8f9a0a2a044c5c77a67f4d6 on mleanos:feature/gulp-test-server-watch-onlyChanged into bc0b4a6 on meanjs:master. |
|
@codydaig @ilanbiala @simison Not trying to complicate the issue here, but I did a refactor on the implementation for this Gulp task. I did this in a separate commit so it can easily be reverted if these changes aren't accepted. I think this is a bit cleaner, and it works as a stand-alone watch task. I don't think it should be grouped in with the other watches, since this is meant for a very specific development task. Also, I removed the dependency on the yargs package, from this task. If the refactor is agreed upon, I'll remove the package from the project as well. Any thoughts? |
|
Coverage remained the same at 70.615% when pulling 1134aabf4fc12393ae4232167d94b407eecbc643 on mleanos:feature/gulp-test-server-watch-onlyChanged into bc0b4a6 on meanjs:master. |
|
LGTM. |
Sets the behavior of the test:server:watch Gulp task to only run a single test suite if the modified server file is a test suite. Previously this was acheived through the use of the `onlyChanged` parameter. The parameter has been removed since this is almost certainly the only use case. Also, refactors this Gulp task to be a stand-alone watch task rather than including it in the 'watch' task. Removed the need for using yargs library, and removed the yargs package from the framework. Closes meanjs#1297
mleanos
force-pushed
the
feature/gulp-test-server-watch-onlyChanged
branch
from
1134aab
to
8a05363
Compare
|
I'll merge if the build passes, since this is a pretty simple change & so that this isn't blocking the progress of #1296. |
The test:server:watch Gulp task has a parameter
onlyChangedthat is used to specify that if a server test file was modified, then only run that test suite. This removes the parameter, and sets the task behavior to the aforementioned.Closes #1297