Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Fix the Google OAuth Redirect Bug - #535 #568

Merged
merged 1 commit into from
Jul 29, 2015
Merged

Fix the Google OAuth Redirect Bug - #535 #568

merged 1 commit into from
Jul 29, 2015

Conversation

floydpink
Copy link
Contributor

Correct the issue of Google OAuth2 redirect missing the hashbang after enabling GooglePlus API - Fixes #535

Thanks to the discussion on #535 and the fix from @junit38

@floydpink
Copy link
Contributor Author

Without this change, G+ auth is broken now. What else do we need for this to get merged?

Who can give the +1 indicated by the label?

@ghost
Copy link

ghost commented Jul 4, 2015

👍
Implemented your changes and fixes the redirect issue for my app.

Thanks

@ilanbiala ilanbiala added this to the 0.4.x milestone Jul 5, 2015
@ilanbiala
Copy link
Member

@floydpink this should be against 0.4.0 if it applies in that branch.

lirantal added a commit that referenced this pull request Jul 29, 2015
Fix the Google OAuth Redirect Bug - #535
@lirantal lirantal merged commit 3bc1de2 into meanjs:master Jul 29, 2015
@lirantal lirantal self-assigned this Jul 29, 2015
@lirantal
Copy link
Member

@ilanbiala I actually merged this into master unintentionally (too many open tabs) although I'm not sure we need to revert if we'll anyway;

  1. release 0.4.0 soon
  2. @pinny87 confirming this works already in master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google authentication callback url bug
4 participants