This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Refactoring the seeded user objects to be easily maintained #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| roles: ['user'] | ||
| }); | ||
| seedUser.password = password; | ||
| var user = new User(seedUser); |
There was a problem hiding this comment.
Why do you add one here when one is removed?
There was a problem hiding this comment.
I didn't make that change, that's part of the original code for the seeding.
IIRC it is removing any existing user and adding a new one so you can gain access to it, and it's only happening when you're on dev/test.
There was a problem hiding this comment.
Yeah okay I missed the brace..
|
Looks like we're good. If no one has anything else to add I'll merge so I can keep working on updates for the seed functionality and testing it. |
|
LGTM. We should merge #801 as well. |
|
LGTM |
lirantal
added a commit
that referenced
this pull request
Sep 9, 2015
Refactoring the seeded user objects to be easily maintained
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.