Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot use typescript definitions from npm package #283

Closed
imjeen opened this issue Aug 25, 2021 · 6 comments
Closed

cannot use typescript definitions from npm package #283

imjeen opened this issue Aug 25, 2021 · 6 comments

Comments

@imjeen
Copy link

imjeen commented Aug 25, 2021

Describe the bug
install the package by npm, nothing about typescript definitions.

To Reproduce
Steps to reproduce the behavior:

  1. npm i html5-qrcode
  2. import Html5Qrcode from 'html5-qrcode'
  3. See error about typescript

Expected behavior

Generate the typescript definitions please.

@omairalamada
Copy link

Any solution for this?

@PhilippSoehnlein
Copy link

PhilippSoehnlein commented Oct 13, 2021

Looks like @EduardMcfly made a fork of version 2.0.9 2.0.6 that includes TypeScript typings.
Install via npm install @cosva-lab/html5-qrcode.

@mebjas
Copy link
Owner

mebjas commented Oct 13, 2021

@EduardMcfly please send a PR if you have a working solution.

@mebjas
Copy link
Owner

mebjas commented Oct 17, 2021

Can you verify with latest version of code with npm update?

(I'll add more documentation later)

@EduardMcfly
Copy link

EduardMcfly commented Oct 18, 2021

@mebjas
I will do a PR very soon to fix that error and also update the version I create

@mebjas
Copy link
Owner

mebjas commented Oct 23, 2021

This should have been fixed in latest version - v2.1.0

Please reopen if this is still an issue.

@EduardMcfly Thanks the solution was greatly inspired from your work.

@mebjas mebjas closed this as completed Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants