-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(tracker): add e2e playwright specs #109
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #98. Does regression testing on Chromium, Chrome, Edge, Firefox and Webkit on macOS and Linux (Windows can only be tested after #36 for us to run a mock API server on the runner).
Typically such a wide matrix isn't needed, but unfortunately different OSes for the same browser do have minor differences in implementations such as
sendBeacon
API or system clocks from previous experimentation, so we need to cover all cases.This PR is an introductory one to setup the framework and covers only the most basic cases. In the future, we should add more comprehensive for various tracking methods such as
data-hash
or new edge cases.Additionally, a bug fix to the tracker is included to help pass some tests when sending
unload
when pressing the back button on the history router 🎉