feat(core): use a new settings struct to support multiple trackers #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 3/? for #9.
This is a major refactor and improvement on how we approach user settings, allowing for settings to be stored in a JSON blob for the root user since performance isn't critical here.
Ideally, what we will have is a
RuntimeConfigthat can be dynamically updated and change what type of script is served from/script.js. Since we didn't actually have a framework for properly storing global settings long term, this PR aims to create a good foundation for that.This will have breaking changes to the API since I went ahead and cleaned up a couple of endpoints such as
GET /settings/usagein favour ofGET /user/usage. We've also removed the ability to set the resource allocation in the usage menu since it was overly complex, filled with footguns, and an extremely niche use case.