Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ally.query.tabsequence: tabindex sorting within ShadowRoot #6

Closed
rodneyrehm opened this issue Dec 28, 2014 · 1 comment
Closed

ally.query.tabsequence: tabindex sorting within ShadowRoot #6

rodneyrehm opened this issue Dec 28, 2014 · 1 comment
Labels
bug
Milestone
1.1.0 - second wave

Comments

@rodneyrehm
Copy link
Member

Because ally.query.focusable can find shadowed elements, util/sort-element-by-tabindex must be extended.

  • The tabindex of an element within a ShadowRoot does not affect the global tabbing order, only the one within the ShadowRoot.
  • Firefox (currently) ignores positive tabindex [tabindex="1"] within ShadowRoot - these elements are not added to the tabbing order. Firefox sorts tabindex globally, not limited to ShadowRoot.

util/sort-element-by-tabindex should sort the children of a ShadowRoot independently of the document. Within a document, the ShadowRoot must be treated as an immutable group.
@rodneyrehm rodneyrehm added the bug label Dec 28, 2014
@rodneyrehm rodneyrehm added this to the v0.1.0 - Focus milestone Dec 28, 2014
@rodneyrehm rodneyrehm modified the milestones: 1.0.0 - Focus Management, 1.1.0 - next steps Sep 26, 2015
@rodneyrehm rodneyrehm changed the title Shadowed tabindex only matter within a ShadowRoot ::shadow [tabindex="123"] ally.query.tabsequence: tabindex sorting withing ShadowRoot Nov 21, 2015
@rodneyrehm rodneyrehm changed the title ally.query.tabsequence: tabindex sorting withing ShadowRoot ally.query.tabsequence: tabindex sorting within ShadowRoot Nov 21, 2015
@rodneyrehm rodneyrehm mentioned this issue Nov 25, 2015
Closed
@rodneyrehm
Copy link
Member Author

Of course it is only Chrome sorting tabindex within a ShadowDOM, while Firefox sorts them globally, as can be whitnessed in this fiddle (sorry, jsbin is down at the moment…)

rodneyrehm added a commit that referenced this issue Dec 10, 2015
@rodneyrehm
fix(query/tabsequence): properly sort tabindex within ShadowDOM - #6
cef6e6a
rodneyrehm added a commit that referenced this issue Dec 10, 2015
@rodneyrehm
docs(query/tabsequence): adding notes on ShadowDOM - #6
18cec6c
@rodneyrehm rodneyrehm mentioned this issue Dec 10, 2015
Merged
rodneyrehm added a commit that referenced this issue Dec 12, 2015
@rodneyrehm
fix(query/tabsequence): properly sort tabindex within ShadowDOM - #6
3608f4f
rodneyrehm added a commit that referenced this issue Dec 12, 2015
@rodneyrehm
docs(query/tabsequence): adding notes on ShadowDOM - #6
4acbe60
rodneyrehm added a commit that referenced this issue Dec 12, 2015
@rodneyrehm
fix(query/tabsequence): properly sort tabindex within ShadowDOM - #6
da38b66
rodneyrehm added a commit that referenced this issue Dec 12, 2015
@rodneyrehm
docs(query/tabsequence): adding notes on ShadowDOM - #6
eecf9ec
@rodneyrehm rodneyrehm removed the ready label Dec 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.1.0 - second wave
Development

No branches or pull requests
1 participant
@rodneyrehm