-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support working with elements in iframes #78
Comments
rodneyrehm
added a commit
that referenced
this issue
Nov 26, 2015
rodneyrehm
added a commit
that referenced
this issue
Nov 26, 2015
Merged
rodneyrehm
added a commit
that referenced
this issue
Nov 26, 2015
fix(core): support testing is/* in iframes - closes #78
rodneyrehm
added a commit
that referenced
this issue
Nov 30, 2015
rodneyrehm
added a commit
that referenced
this issue
Nov 30, 2015
rodneyrehm
added a commit
that referenced
this issue
Dec 1, 2015
rodneyrehm
added a commit
that referenced
this issue
Dec 1, 2015
rodneyrehm
added a commit
that referenced
this issue
Dec 3, 2015
rodneyrehm
added a commit
that referenced
this issue
Dec 3, 2015
rodneyrehm
added a commit
that referenced
this issue
Dec 3, 2015
rodneyrehm
added a commit
that referenced
this issue
Dec 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Any module accepting a
context
argument should usecontext.ownerDocument
(instead ofdocument
) to query the DOM, in order to be able to work with elements in nested iframes. Currently this fails for (at least)utils/node-array
(instanceof is not a good idea)get/insignificant-branches
is/is.util
query/focusable.strict
when/focusable
That is about the scope we need to allow running the
is/*
tests against elements in an iframe.To make this really work, we'd have to do quite some more:
document
andwindow
need to go throughelement.ownerDocument
andelement.ownerDocument.defaultView
respectivelyinstanceof
operator must be replaced by a window-independent alternativeWe'll go for the simple solution (not covering
window
andinstanceof
) until someone actually needs to do this - in which case we'll expect another issue being opened.The text was updated successfully, but these errors were encountered: