Issue/107 shadow root disengage #108
Conversation
…ling undoElementInert
Add element to interElementsCache when inert is set and remove when undo is called. This will work for MutationsObserver as well since the same function will be called
| @@ -20,11 +20,19 @@ import queryFocusable from '../query/focusable'; | |||
| import elementDisabled from '../element/disabled'; | |||
| import {getParentComparator} from '../util/compare-position'; | |||
|
|
|||
| let inertElementSet = []; | |||
There was a problem hiding this comment.
you can have multiple instances of InertSubtree and the list of elements belongs on that class.
|
right, looking better now :) Shame we have to find a solution for #95 before PRs like yours are actually tested on Travis :( Do you want to take care of the other tasks in that issue as well? |
|
Oh, #95 is blocking all PRs? Bummer. The MutationObserver piece seems like a separate bug to me since it's never actually been observing shadow-root items. I'm happy to work on this issue as well though. What's your thought about me adding a new issue to define the shadow-root MutationObserver issue? |
not all, only the ones not originating from this repo. (which is basically everyone but Marcy and me…)
I don't care either way… |
|
ok, "solved" the travis issue. please sync your fork and rebase your branch on master (thereby squashing your 3 commits into 1). Then you'll have to force push. After that your branch should be tested on Travis. You can then have a look at adding a test for your changes… |
|
I'm on it. |
|
I've pulled your changes into issue/107-maintain-shadows (maintaining your authorship) and resolved a few things. once the tests pass, I'll merge that branch and close this PR. thank you! :) |
Fix for undo inert on all elements, including shadow-root. Fixes: #107