Feature/vite scripts dev mode #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default setting, depending on the order of how plugins are configured, would result in the HMR plugin code being injected AFTER the entry script. This would mean that component code would execute before HMR code was set up, and would fail. Potentially there are 3 options to fix this; 1) change `enforce: 'pre'` to `post` to allow executing after other plugins 2) change the order of plugins in `scripts/react-vite/config` to append the `react-vite` plugin before the super plugins, but that could have other side-effects in the future. 3) change the `injectTo` from `prepend-head` to `head` to make sure it's always injected into other Here the 3rd option is chosen.
jesse-mm
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use dev mode by default when NODE_ENV var is not set
Otherwise locally you would use production mode when running
npm run dev, which is unexpected.After fixing that, I ran into another issue:
vite-scripts: Change injection point of entry path in HTML
The default setting, depending on the order of how plugins are
configured, would result in the HMR plugin code being injected AFTER the
entry script. This would mean that component code would execute before
HMR code was set up, and would fail.
Potentially there are 3 options to fix this;
enforce: 'pre'topostto allow executing after other pluginsscripts/react-vite/configto append thereact-viteplugin before the super plugins, but that could have other side-effects in the future.injectTofromprepend-headtoheadto make sure it's always injected into otherHere the 3rd option is chosen.