Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds sms duplicate limit documentation. #55

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

dianabarsan
Copy link
Member

Copy link
Member Author

@dianabarsan dianabarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review, @abbyad .

relevantLinks: >
docs/apps/concepts/workflows
docs/design/apps
docs/apps/guides/africas-talking
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea how to get this to work. relevantLinks seems to not be documented in docsy : https://www.docsy.dev/search/?q=relevantLinks

In the actual page, some additional "Related Content" links are being added magically.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Related Content is generated by the matching of keywords.

The relevantLinks was a custom field we were using at some point to specify explicitly which pages to show as "Related Content". Now that we have more content we can figure out what the best approach is, and also document it too.

Copy link
Contributor

@abbyad abbyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition!

@abbyad abbyad merged commit 451d739 into master Jun 4, 2020
@abbyad abbyad deleted the 6094-configurable-duplicates branch June 4, 2020 13:45
@dianabarsan
Copy link
Member Author

Oh oops, I don't think this should have been merged, the issue is still in AT.

@abbyad
Copy link
Contributor

abbyad commented Jun 10, 2020

Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants