Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KR: Feature Flags for previous Material Design elements have been removed #25

Closed
4 tasks done
michaelkohn opened this issue Feb 7, 2024 · 8 comments
Closed
4 tasks done
Milestone

Comments

@michaelkohn
Copy link
Member

michaelkohn commented Feb 7, 2024

CHT Core ticket: medic/cht-core#8181

To achieve that we need to complete these 3 tasks:

@michaelkohn michaelkohn modified the milestones: 2024 Q2, 2024 Q3 Feb 7, 2024
@latin-panda
Copy link
Collaborator

Original for tracking: medic/cht-core#8181

@latin-panda
Copy link
Collaborator

@michaelkohn I've separated this one into two tickets just for internal project management, while keeping the big ticket in medic/cht-core#8181
Two people working simultaneously will step on each other because the files to refactor are the same (reports and contact pages)

@michaelkohn
Copy link
Member Author

Gotcha, thanks.

One other thing to consider is that, while we did agree that we can remove those feature flags earlier / in a separate release from the NAV updates themselves, my hope is that they are not released with a big time gap between them. If it's not much extra work, I'd like to keep the feature flags around as long as possible before we release the NAV updates. The logic is... if there is something that projects need / want in a release between when we remove the old feature flags and when we add the new NAV, I don't want the removal of the old feature flags to become a blocker for those projects (since the new UI will likely become one).

@latin-panda
Copy link
Collaborator

latin-panda commented Jul 15, 2024

@michaelkohn is this still part of Q3 KRs?

@michaelkohn
Copy link
Member Author

Yes

@latin-panda
Copy link
Collaborator

@michaelkohn
All tasks are completed.
When we agree to release this work, we update this PR with the latest changes in CHT Core, do a final review, final test, and merge for releasing it in CHT.

Leaving this KR open for now

@michaelkohn
Copy link
Member Author

👍 perfect, thanks @latin-panda

@latin-panda
Copy link
Collaborator

Work delivered (PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants