fix(#26): add warning if jsonDir contains file when running csv-to-doc command

[sugat009]

Description

Added warning if jsonDir contains files when running csv-to-doc command.

#26

Screenshots

1. When jsonDir does not exists
   
2. When jsonDir exists and user wants to continue after prompt is shown
   
3. When jsonDir exists and user does not want to continue after prompt is shown
   

Code review items

• Readable: Concise, well named, follows the style guide, documented if necessary.
• Documented: Configuration and user documentation on cht-docs
• Tested: Unit and/or integration tests where appropriate
• Backwards compatible: Works with existing data and configuration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

[jkuester]

So great! You did an awesome job of paying attention to the patterns and functionality of existing code and matching that with your new additions!

Can you also add two tests to the csv-to-docs.spec.js file, one where the user accepts the prompt and one where the user rejects it? I think you should be able to mock the userPrompt functionality with sinon similar to what is happening in the edit-contacts.spec tests.

[jkuester]

Also, I added @tatilepizs to this PR so we can get QA's perspective here too!

[andrablaj]

@jkuester, my bad for not having @tatilepizs added to this PR, and thanks for doing that. @sugat009 asked me about it this morning, and as it was a small change and the PR was already ready for review I figured that it didn't need extra QA support. Thanks for keeping me honest!

[tatilepizs]

That is fine @andrablaj, and thank you @jkuester 🙂
What I like about those PRs is that I am constantly learning about the development and the feedback

[tatilepizs]

I don't have anything else to add.
Thank you @sugat009 ⭐

[m5r]

Well done on landing your first PR for cht-conf, @jkuester and @tatilepizs covered pretty much everything I had in mind 😄
I added a few comments, let me know if you have any question

[jkuester]

Sorry, I think when I first looked at this, I was looking at an older version of the code and I did not see that warnIfDirectoryIsNotEmpty was getting exported. (Which probably made at least some of my comments more confusing...)

[jkuester]

This is great! Thanks for the careful revisions! I just had one more minor request for an assertion in the csv-to-docs.spec.js. I am going to approve this PR now, though, meaning that I don't think I need to review how you implemented the changes I requested (this is a common practice at Medic, especially for minor test changes like this. Just helps reduce unnecessary feedback loops since we are all working async). If you do have any questions/concerns with the changes, you can always re-request my review. Otherwise, if everything looks good to you, once you get that assertion added, this PR is good to merge (already have approval from QA)!

You should have permissions to click the merge button. Just make sure it is doing a "squash merge" and the commit message is following the convention. Both of these should be done automatically based on our repo settings (which is why we always merge to main via the PR webpage on GitHub (and not via the CLI or anything) since it will enforce this stuff). The commit message format is very important since merging to master will trigger the semantic-release plugin to try and automatically cut a new release of cht-conf based on the info in the commit message.

OOO

[medic-ci]

🎉 This PR is included in version 3.21.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀