Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#615): add support for assetlinks.json when compiling app settings #616

Merged
merged 6 commits into from
Apr 29, 2024

Conversation

m5r
Copy link
Member

@m5r m5r commented Apr 25, 2024

Description

#615

Code review items

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or integration tests where appropriate
  • Backwards compatible: Works with existing data and configuration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent! Just one minor request for unit tests.

src/lib/validate-app-settings.js Show resolved Hide resolved
Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m5r m5r merged commit f39d22a into main Apr 29, 2024
14 checks passed
@m5r m5r deleted the support-assetlinks branch April 29, 2024 15:28
@medic-ci
Copy link
Collaborator

🎉 This PR is included in version 3.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants