-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock the android app when returning to foreground #3237
Comments
This is working. Waiting for @diannakane or @amandacilek for design input. |
@alxndrsn can you provide more detail here? What has been implemented? What input is needed? This is also a significant change that will affect large-scale partners so the roll-out of this feature needs to be done carefully. |
@sglangevin I'm hoping to demo to someone from the design team, although perhaps you would be more appropriate. If you're interested I can send you a build with the feature enabled and if desired talk you through it. |
I am interested to see a demo soon if we can make time for that. I'd like to understand the details of how it was implemented and what other things we need to do (if any) before it could be rolled out. I'd also like to make sure I'm fully up to speed on how it works so that I can help support the roll-out of this feature. I'll need to know how it would affect existing users vs. new users who are logging in for the first time. Perhaps we can go through it together and then I can chat with the design team about what is needed from their end? If you're around tomorrow morning your time (tonight my time) we could do it then. |
@sglangevin I think this is really a design issue now. If designers are using this ticket to track the issue then leave it here; if not, perhaps we can close it? |
Normally tickets would be tracked with a design issue first before development, but since we did this in a slightly different order, let me talk to @diannakane and she can provide feedback. Depending on the changes, we can decide whether to open a new issue or continue with this one. |
@alxndrsn great initial mockups! I have a few questions and suggestions. @amandacilek has offered to help with final polishing, but if you can take another stab at the UX/UI with these considerations, that'd be helpful. Overall features and navigation:
UI:
cc: @amandacilek |
@diannakane great feedback, thanks!
On older phones, you press the hardware menu button. On newer phones, it may be accessible via a long-press of the back button. There's an open issue to deal with this at medic/cht-android#33
Try clicking on them - nothing terrible will happen.
Delete all app data. Another option might be to phone or visit your branch and get a PUK code issued. This would basically be the same process as re-logging in after re-installing the app, except that you wouldn't need to re-download the whole database again. OTOH it would be a lot more process and involve extra functionality in both the android wrapper and webapp/api.
I think it's just
There's currently no requirement that a PIN should have a specific length. Is this a recommendation for a 4-digit PIN?
Backspace seems more intuitive/useful to me, but perhaps because I'm used to Android and iPhone unlock screens, which both have an "erase last-entered number" button. OTOH on iPhone it's actually very annoying...
As above, there's no length requirement. From a security point of view, displaying the length of a password is not generally recommended, and sometimes not possible.
👍 there are a lot of improvements to be made in this area, along with deciding when a user should set their PIN - perhaps it would be part of training. |
What unlock screen are you referring to that is in use? I don't know if I've seen it, but may be misunderstanding. |
I'm referring to the OS-level lock screen. |
We are planning to have the design team work on this before implementing something. As far as I know there are no mockups, just a prototype Android app that @alxndrsn had shared. He can send you the apk if you'd like to see it. |
I can't find the prototype that I provided feedback on. @alxndrsn please re-share. |
Should be available in the latest |
This needs design input before we can proceed any further so I'm removing this from the milestone. |
@garethbowen can we archive this? Seems to be replaced by #6380 |
I agree, it's probably a duplicate, however this one is security focussed, and that one is user workflow focussed, so I'd like to keep them both around to ensure that both concepts are considered and tested. |
Implement a PIN (or similar) to unlock access to the app when bringing the app back to the forground. This will help protect when a phone is borrowed or stolen.
More information
The text was updated successfully, but these errors were encountered: