Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bootstrap-datepicker translations for Tagalog (tl) Illonggo (hil) and Bisaya (ceb) languages #6849

Closed
kennsippell opened this issue Jan 15, 2021 · 11 comments
Closed

Add bootstrap-datepicker translations for Tagalog (tl) Illonggo (hil) and Bisaya (ceb) languages #6849

kennsippell opened this issue Jan 15, 2021 · 11 comments
Assignees
@ngaruko @binokaryg @dianabarsan
Labels
Translations Affects internationalization Type: Feature Add something new

Comments

@kennsippell
Copy link
Member

Is your feature request related to a problem? Please describe.
A new app in the Philippines is requriing language support for Tagalog, Illonggo, and Bisaya. In addition to #6848 (blocking), the project will also require translations for the bootstrap datepicker.

Describe the solution you'd like
Create translations and add them for these languages.
@kennsippell kennsippell added the Type: Feature Add something new label Jan 15, 2021
@binokaryg
Copy link
Member

Thanks Kenn. I have asked the local partner for the required translations.

@MaxDiz MaxDiz added the Translations Affects internationalization label Jan 19, 2021
@MaxDiz
Copy link
Contributor

MaxDiz commented Jan 19, 2021

@binokaryg do you know the timing required for this project deployment?

@binokaryg
Copy link
Member

binokaryg commented Jan 19, 2021 •
edited
Loading

The project has already been deployed and the CHWs have started collecting data from yesterday. They are currently being guided by their trainers who know English or Tagalog (it is working). Starting mid-Feb, the CHWs will start working solo. We need to get the translations working at least a few weeks before that so that the training can continue in a language they know.
So I would say, it would be great if we can get it done by early next week (Jan 25).

@MaxDiz
Copy link
Contributor

MaxDiz commented Jan 19, 2021

@ngaruko please pick this up for QA as soon as @binokaryg has completed the PR to align with project timing

@binokaryg binokaryg mentioned this issue Jan 20, 2021
Closed
@binokaryg
Copy link
Member

@joymkimmel do we have the translations finalized yet?

@joymkimmel joymkimmel mentioned this issue Jan 21, 2021
Closed
@joymkimmel
Copy link

Completed the pull request for this.

#6865

@dianabarsan dianabarsan mentioned this issue Jan 21, 2021
Merged
@dianabarsan
Copy link
Member

Ready for AT on 6849-adds-bootstrap-datepicker-locales

@ngaruko ngaruko self-assigned this Jan 21, 2021
@ngaruko
Copy link
Contributor

ngaruko commented Jan 21, 2021 •
edited
Loading

LGTM

  • Tested on branch 6849-adds-bootstrap-datepicker-locales. (date picker, death report.... and dob for new person) - datepicker shows months and short months as in webapp/src/js/enketo/bootstrap-datepicker.ceb.js and webapp/src/js/enketo/bootstrap-datepicker.hil.js respectively.
    image
    Wondering though if the report filter by date use the same logic/date picker. It does not seem to be translated @dianabarsan ?
    image

@dianabarsan
Copy link
Member

The report date filter uses moment dates! it should have proper month names in @binokaryg 's PR!

@ngaruko
Copy link
Contributor

ngaruko commented Jan 21, 2021 •
edited
Loading

Thanks @dianabarsan . Then this looks good. Feel free to merge. I will move onto the other PR.
Looks good on @binod's repo
image

craig-landry added a commit that referenced this issue Jan 21, 2021
@craig-landry
Adds release notes for 3.10.2
4e537fd 
#6848
#6849
#6861
@craig-landry craig-landry mentioned this issue Jan 21, 2021
Merged
craig-landry added a commit that referenced this issue Jan 21, 2021
@craig-landry
Adds release notes for 3.10.2
482b778 
#6848
#6849
#6861
@dianabarsan dianabarsan self-assigned this Jan 22, 2021
dianabarsan added a commit that referenced this issue Jan 22, 2021
@dianabarsan
Adds bootstrap datepicker locales (#6868)
239eae0 
Cherry picks locales from #6865
Fixes linting, enables the languages and normalizes locale codes, as agreed upon here: #6861 (comment)

#6849
dianabarsan added a commit that referenced this issue Jan 22, 2021
@dianabarsan
Adds bootstrap datepicker locales (#6868)
debf059 
Cherry picks locales from #6865
Fixes linting, enables the languages and normalizes locale codes, as agreed upon here: #6861 (comment)

#6849

(cherry picked from commit 239eae0)
@dianabarsan
Copy link
Member

Merged into master and backported to 3.10.x.

craig-landry added a commit that referenced this issue Jan 23, 2021
@craig-landry
Adds release notes for 3.10.2
1e9f0d9 
#6848
#6849
#6861
@dianabarsan dianabarsan mentioned this issue Jan 26, 2021
Open
@garethbowen garethbowen mentioned this issue Jan 31, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ngaruko ngaruko

@binokaryg binokaryg

@dianabarsan dianabarsan

Labels
Translations Affects internationalization Type: Feature Add something new
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ngaruko @kennsippell @binokaryg @dianabarsan @MaxDiz @joymkimmel