Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message queue not loading when translations are missing #5272

Closed
dianabarsan opened this issue Jan 23, 2019 · 1 comment
Closed

Message queue not loading when translations are missing #5272

dianabarsan opened this issue Jan 23, 2019 · 1 comment
Assignees
@tookam @ngaruko
Labels
Configuration Affects the Admin app Priority: 3 - Low Can be bumped from the release Type: Bug Fix something that isn't working as intended

Comments

@dianabarsan
Copy link
Member

When loading Admin's message queue, we try to load all languages in Angular before generating messages. We do that by iterating over all languages and issuing a call to Angular Translate, which effectively loads the language.
If the key we are trying to translate doesn't exist, Angular Translate throws an error and, as a result, the message queue does not load.

image

Discovered after translations failed to be updated by an upgrade (#5271).
@dianabarsan dianabarsan added Type: Bug Fix something that isn't working as intended Configuration Affects the Admin app Priority: 3 - Low Can be bumped from the release labels Jan 23, 2019
@tookam tookam self-assigned this Jan 24, 2019
dianabarsan pushed a commit that referenced this issue Jan 25, 2019
@tookam @dianabarsan
Message queue - default translation to key when missing
47f6f4b 
#5272
@tookam tookam mentioned this issue Jan 25, 2019
Merged
5 tasks
@ngaruko ngaruko self-assigned this Feb 12, 2019
@ngaruko
Copy link
Contributor

ngaruko commented Feb 12, 2019

LGTM
image

@ngaruko ngaruko closed this as completed Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tookam tookam

@ngaruko ngaruko

Labels
Configuration Affects the Admin app Priority: 3 - Low Can be bumped from the release Type: Bug Fix something that isn't working as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tookam @ngaruko @dianabarsan