Prefer Scheduling on OCP Infra Nodes #109
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test 4.14-openshift-e2e |
Infra nodes are a better fit than control plane nodes on OCP, thus we prefer NMO pod to be scheduled on an infra node over a control plane node
|
/test 4.15-openshift-e2e |
config/manager/manager.yaml
Outdated
| preference: | ||
| matchExpressions: | ||
| - key: node-role.kubernetes.io/infra | ||
| operator: In |
There was a problem hiding this comment.
I think using Exists without values is a safer bet
config/manager/manager.yaml
Outdated
| - key: node-role.kubernetes.io/master | ||
| operator: Exists | ||
| - matchExpressions: | ||
| operator: In |
There was a problem hiding this comment.
In doesn't make sense without values, this needs to be Exists
config/manager/manager.yaml
Outdated
| - key: node-role.kubernetes.io/control-plane | ||
| operator: Exists | ||
| operator: In |
config/manager/manager.yaml
Outdated
| - effect: NoSchedule | ||
| key: node-role.kubernetes.io/infra | ||
| operator: Exists | ||
| value: reserved |
There was a problem hiding this comment.
value does not make sense with Exists, only with Equal. But using no value is better as suggested above, I'd remove value
config/manager/manager.yaml
Outdated
| - effect: NoExecute | ||
| key: node-role.kubernetes.io/infra | ||
| operator: Exists | ||
| value: reserved |
Safer and relaxed and taint conditions using exist rather than empty In or specefic In
|
/test 4.14-openshift-e2e |
1 similar comment
|
/test 4.14-openshift-e2e |
|
/lgtm |
|
/retest |
Infra nodes are a better fit than control plane nodes on OCP, thus we prefer NMO pod to be scheduled on an infra node over a control plane node.
See pod scheduling weight and Infra Node.
ECOPROJECT-1660