Webpack support, fix cross-browser incompatibility, improved documentation and more general styling #3
Conversation
| @@ -36,6 +37,9 @@ module.exports = function (/*options*/) { | |||
| return function (deck) { | |||
| var update, current, resolvedQuery; | |||
|
|
|||
| /* If `classes` hasn't been initialized jet, do it now */ | |||
| if (!deck.parent.classList.contains('parent')) classes()(deck); | |||
There was a problem hiding this comment.
Shouldn't it be 'bespoke-parent' ?
There was a problem hiding this comment.
Of course it should. Sorry :)
I just read addClass(deck.parent, 'parent') in the source code of bespoke-classes and didn't properly read what addClass actually did.
Fixing it...
|
I've tested it with one of my presentations and it works great. I'm ready to take it, just let's fix this class name. Thank you! |
|
Happy to hear! I just pushed the fix for the |
|
@Kriegslustig I assume that after this changes is taken, there's no longer need for Can you confirm you see it same way? |
|
Oh, yes. Sorry, I didn't read through the whole source. I'll submit another PR. |
|
@Kriegslustig it's fine, I was just removing it myself, just wanted to confirm with you, that I don't miss anything :) |
|
Thanks :) |
|
Published as v2.0.0 |
Webpack Support
requires now use file extensions for better Webpack support.Cross-browser incompatibility
Replace the non standard use of
Event.srcElementwithEvent.target.Improve documentation
Adds an example of how markup of sides using this extension may look.
Add undeclared dependency to
bespoke-classesbespoke-classesis only added if you use a theme. So the extension actually didn't work when you didn't. This addsbespoke-classesas a dependency and initializes it, if it hasn't been done yet.More general styling
In earlier versions the slides had to be a specific size. I personally like to make my slides
w:100vw; h:100vh. This PR uses a more general approach to the problem usingtransform. This last change requires a major (or at least a minor) version bump, so sorry for putting this all in one PR.