Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USPS support #1

Merged
merged 43 commits into from
Jul 3, 2019
Merged

USPS support #1

merged 43 commits into from
Jul 3, 2019

Conversation

aaronmwhitehead
Copy link
Contributor

No description provided.

aaronmwhitehead and others added 21 commits June 27, 2019 11:53
@aaronmwhitehead
Formatted data nicely
a234578
@aaronmwhitehead
Fixed a lot of things
576abb6
@aaronmwhitehead
More error handling
322e9d1
add invalid credentials test
8a1331d
@aaronmwhitehead
Default options for ClientIp and SourceId
b959987
@aaronmwhitehead
Merge branch 'master' into usps-support
5b0fb1a
@aaronmwhitehead
Moved usps and pitneyBowes into their own files
eb75c06
@aaronmwhitehead
Merge branch 'master' into usps-support
5fe770c
add reg expressions usps and pitneybowes
90b0700
@aaronmwhitehead
Merge branch 'master' into usps-support
ab0798b
@aaronmwhitehead
Alphabetical order for guessing tracking numbers
c300d65
@aaronmwhitehead
Moved usps test to own file. Cleaned usps data with geo utils.
82fed69
@aaronmwhitehead
Changed USERID to USPS_USERID
b7af236
@aaronmwhitehead
Remove .only
5af21a2
@aaronmwhitehead
Added package details
91ffe04
@aaronmwhitehead
Added shippedAt and deliveredAt fields to results
043e46d
add valid tracking number test
3549588
Merge branch 'usps-support' of https://github.com/mediocre/bloodhound …
6597b71 
…into usps-support
remove describe.only
87507d7
remove pitneybowes isTrackingNumberValid
f31cd6a
Added a test to return an error for an invalid URL
9fe9043
freshlogic
freshlogic requested changes Jul 3, 2019
View reviewed changes
Copy link
Member

@freshlogic freshlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event.Date is already a Date. We shouldn't need to create a new Date from it for shippedAt and deliveredAt

@freshlogic
Docs read "These events are never generated by a physical scan from t…
0f4e6b3 
…he Postal Service" which means we can't use them for this purpose
freshlogic
freshlogic requested changes Jul 3, 2019
View reviewed changes
Copy link
Member

@freshlogic freshlogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to remove status codes where the docs said "These events are never generated by a physical scan from the Postal Service". These are the codes we need to avoid.

I'd like to see at least one test assertion where we're comparing full actual vs expected data returned from usps.track().

@freshlogic
Copy link
Member

Need to cover these lines:

@freshlogic freshlogic merged commit 503d3cb into master Jul 3, 2019
@freshlogic freshlogic deleted the usps-support branch July 3, 2019 22:12
@freshlogic freshlogic restored the usps-support branch July 3, 2019 22:12
@freshlogic freshlogic deleted the usps-support branch July 3, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freshlogic freshlogic freshlogic requested changes

@javamatte javamatte Awaiting requested review from javamatte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronmwhitehead @freshlogic