Add missing assert for test "correctly redirects for a file whose fiename contains something looking like a hash" #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2014 17:00
…ename contains something looking like a hash", which exposes a bug in the framework or an error in the assumption of the test.
|
only dehash when hash value is exactly 32 chars long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path provided in the test "/robots-3e.txt" is dehashified to "/robots.txt", which is then hashified to "/robots-ca121b5d03245bf82db00d14cee04e22.txt". This is not match for the expected url. The added assert now shows a failure.
Either we should change the expected value in the test to "/robots-ca121b5d03245bf82db00d14cee04e22.txt"
OR
We should ONLY dehashify urls that contain actual 32 character hashes
I am not certain why we would want to redirect for filenames that have something that looks like a hash, rather than actually having a hash.