Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modal is closing when click on it #682

Closed
samueljohnprasad opened this issue Jul 15, 2022 · 0 comments · Fixed by #683
Closed

fix: modal is closing when click on it #682

samueljohnprasad opened this issue Jul 15, 2022 · 0 comments · Fixed by #683
Assignees
@abhishekashyap
Labels
bug Something isn't working

Comments

@samueljohnprasad
Copy link

samueljohnprasad commented Jul 15, 2022 •
edited
Loading

Describe the bug

  • modal should close when clicked outside of it, present it is closing the modal when clicking on it as well

To Reproduce

  1. pass shouldCloseOnOutsideClick props to the modal, and click anywhere on the modal
    it should not close the modal, it should only close the modal when clicked outside the modal.

Expected behavior

Provide a clear and concise description of the behaviour expected in the above-mentioned scenario.

Screenshots

If applicable, provide screenshots to explain the bug.

Package versions

    '@medly-components/core@6.16.0',
    '@medly-components/forms@2.1.66',
    '@medly-components/icons@1.12.11',
    '@medly-components/layout@3.2.20',
    '@medly-components/loaders@1.6.10',
    '@medly-components/theme@5.2.0',
    '@medly-components/utils@2.2.0',

Additional context

Provide any additional information about the bug or the bug scenario.
@samueljohnprasad samueljohnprasad added the bug Something isn't working label Jul 15, 2022
@abhishekashyap abhishekashyap self-assigned this Jul 15, 2022
abhishekashyap added a commit that referenced this issue Jul 15, 2022
@abhishekashyap
test: add tests to fix closing of modal on clicking of modal
fd2b24c 
affects: @medly-components/core

ISSUES CLOSED: #682
@abhishekashyap abhishekashyap mentioned this issue Jul 15, 2022
Merged
20 tasks
gmukul01 pushed a commit that referenced this issue Jul 18, 2022
@abhishekashyap
fix: should not close modal on clicking on modal (#683)
42ab863 
* revert: modal popup stop propagation function

affects: @medly-components/core

* chore: update dependencies for handlebgclick

affects: @medly-components/core

* test: add tests to fix closing of modal on clicking of modal

affects: @medly-components/core

ISSUES CLOSED: #682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhishekashyap abhishekashyap

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: should not close modal on clicking on modal medly/medly-components
2 participants
@samueljohnprasad @abhishekashyap