Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Select field option list doesn't get change when used inside modal form component.. #688

Closed
Shreyasgkhakal100 opened this issue Jul 26, 2022 · 0 comments · Fixed by #689
Closed

bug: Select field option list doesn't get change when used inside modal form component.. #688

Shreyasgkhakal100 opened this issue Jul 26, 2022 · 0 comments · Fixed by #689
Labels
bug Something isn't working

Comments

@Shreyasgkhakal100
Copy link
Collaborator

Describe the bug

We have created Modal having form component inside it & our form has single select field which is for selecting state.
When user click on select field then options get visible to the user but if user click outside of that options but inside of modal or select on any other form field then also option remains visible. Ideally it should get hide.

It works as expected if we click outside of modal but it doesn't work if we click anywhere inside modal.

To Reproduce

Provide step-by-step instructions to reproduce the bug:

  1. Create Modal having form component inside Modal.Content.
  2. Form component should contained at least one single select field in it e.g. Select State.
  3. Then See this component on ui then you will get to know about this bug.

Expected behavior

Ideally it should get hide if user click anywhere out side select options of the field.

Screenshots

If applicable, provide screenshots to explain the bug.
image

Package versions

  • @medly-components/core :
  • @medly-components/forms :
  • @medly-components/icons :
  • @medly-components/layout :
  • @medly-components/loaders :
  • @medly-components/theme :
  • @medly-components/utils :

Additional context

Provide any additional information about the bug or the bug scenario.
@Shreyasgkhakal100 Shreyasgkhakal100 added the bug Something isn't working label Jul 26, 2022
gmukul01 added a commit that referenced this issue Jul 26, 2022
@gmukul01
fix: modal close issue on click on outside of modal
13fdd90 
affects: @medly-components/core

ISSUES CLOSED: #688
@gmukul01 gmukul01 mentioned this issue Jul 26, 2022
Merged
20 tasks
gmukul01 added a commit that referenced this issue Jul 27, 2022
@gmukul01
fix: modal close issue on click on outside of modal (#689)
cab6cad 
* fix: modal close issue on click on outside of modal

affects: @medly-components/core

ISSUES CLOSED: #688

* fix: type issue in modal component

affects: @medly-components/core

* refactor: importing MouseEvent directly

affects: @medly-components/core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: modal close issue on click on outside of modal medly/medly-components
1 participant
@Shreyasgkhakal100