Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Single select focus issue #720

Closed
Bhusnar5044 opened this issue May 8, 2023 · 0 comments · Fixed by #721
Closed

bug: Single select focus issue #720

Bhusnar5044 opened this issue May 8, 2023 · 0 comments · Fixed by #721
Labels
bug Something isn't working

Comments

@Bhusnar5044
Copy link
Contributor

Describe the bug

Single-select focus not going away when we select the option. It works only when we open the options pop-up and then click outside without selecting an option.

To Reproduce

Provide step-by-step instructions to reproduce the bug:

  1. Go to Single Select component
  2. Click on the field to select an option after selecting perform the outside click event.
  3. then press the up/down arrow key, it will open the Options pop-up.

Expected behavior

when we click an option from a single select option pop-up, the field focus should not be there on the outside click event.

Package versions

  • @medly-components/core : 6.26.1

Additional context

Provide any additional information about the bug or the bug scenario.
@Bhusnar5044 Bhusnar5044 added the bug Something isn't working label May 8, 2023
Bhusnar5044 added a commit to Bhusnar5044/medly-components that referenced this issue May 8, 2023
@Bhusnar5044
fix(core): fixed single-select focus issue on outside click of container
a2b0e43 
affects: @medly-components/core

ISSUES CLOSED: medly#720
Bhusnar5044 added a commit to Bhusnar5044/medly-components that referenced this issue May 8, 2023
@Bhusnar5044
test(core): added test cases for single select focus handling on outs…
825cd82 
…ide click

affects: @medly-components/core

ISSUES CLOSED: medly#720
@Bhusnar5044 Bhusnar5044 mentioned this issue May 8, 2023
Merged
20 tasks
gmukul01 pushed a commit to Bhusnar5044/medly-components that referenced this issue May 8, 2023
@Bhusnar5044
PSB | fix: single select focus Issue (medly#721)
9ad98c4 
* fix(core): fixed single-select focus issue on outside click of container

affects: @medly-components/core

ISSUES CLOSED: medly#720

* test(core): added test cases for single select focus handling on outside click

affects: @medly-components/core

ISSUES CLOSED: medly#720

* refactor(core): fixed smell code

affects: @medly-components/core

* test(core): renamed test cases, to fix test case dublications

affects: @medly-components/core
gmukul01 added a commit that referenced this issue May 8, 2023
@Bhusnar5044 @gmukul01
fix(core): single select focus Issue (#721)
683924d 
* fix(core): fixed single-select focus issue on outside click of container

affects: @medly-components/core

ISSUES CLOSED: #720

* test(core): added test cases for single select focus handling on outside click

affects: @medly-components/core

ISSUES CLOSED: #720

* refactor(core): fixed smell code

affects: @medly-components/core

* test(core): renamed test cases, to fix test case dublications

affects: @medly-components/core

---------

Co-authored-by: Mukul Bansal <mukulbansal01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): single select focus Issue Bhusnar5044/medly-components
1 participant
@Bhusnar5044