Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: SingleSelect - search filter not working well due to duplicate key issue. #732

Closed
Bhusnar5044 opened this issue Jun 26, 2023 · 0 comments · Fixed by #733
Closed

bug: SingleSelect - search filter not working well due to duplicate key issue. #732

Bhusnar5044 opened this issue Jun 26, 2023 · 0 comments · Fixed by #733
Labels
bug Something isn't working

Comments

@Bhusnar5044
Copy link
Contributor

Describe the bug

SingleSelect - search option not showing the specific option, it shows other options as well. We have used the label as a key for Options React facing difficulty in figuring out the change.

To Reproduce

Provide step-by-step instructions to reproduce the bug:

  1. add duplicate options with the same label.
  2. filter options using a search filter.
  3. You can check now it doesn't show filtered options.

Expected behavior

If there is a duplicate option with the same label and different value, and the user tries to search the option, it should show only searched options.

Screenshots

If applicable, provide screenshots to explain the bug.

Package versions

  • @medly-components/core : 6.27.0
@Bhusnar5044 Bhusnar5044 added the bug Something isn't working label Jun 26, 2023
Bhusnar5044 added a commit to Bhusnar5044/medly-components that referenced this issue Jun 26, 2023
@Bhusnar5044
fix(core): singleSelect - search filter not working well due to dupli…
0e082f7 
…cate key issue.

affects: @medly-components/core

ISSUES CLOSED: medly#732
@Bhusnar5044 Bhusnar5044 mentioned this issue Jun 26, 2023
Merged
20 tasks
gmukul01 added a commit that referenced this issue Jul 5, 2023
@Bhusnar5044 @gmukul01
fix(core): singleSelect - search filter not working well due to dupli…
3c37a28 
…cate key issue. (#733)

* fix(core): singleSelect - search filter not working well due to duplicate key issue.

affects: @medly-components/core

ISSUES CLOSED: #732

* refactor(core): singleSelect: Removed index from option key value

affects: @medly-components/core

---------

Co-authored-by: Mukul Bansal <mukulbansal01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@Bhusnar5044