Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodingInput lost label in Medplum v3 #3751

Closed
dillonstreator opened this issue Jan 19, 2024 · 1 comment · Fixed by #3782
Closed

CodingInput lost label in Medplum v3 #3751

dillonstreator opened this issue Jan 19, 2024 · 1 comment · Fixed by #3782
Assignees
Labels
react Features, fixes and enhancements to react component library

Comments

@dillonstreator
Copy link
Contributor

I'm upgrading to Medplum v3 & Mantine 7 and noticed CodingInput no longer propagates label as well as most other allowed props. This is due to the lower-level CodingInput dependencies (ValueSetAutocomplete -> AsyncAutocomplete) not fully leveraging their input props.

It's an easy fix to just have the caller manage the label but thought I'd open this as there are a bunch of props that are now going into the void causing weird DX.

@reshmakh reshmakh added the react Features, fixes and enhancements to react component library label Jan 19, 2024
@codyebberson
Copy link
Member

Oh no! Thanks @dillonstreator

@codyebberson codyebberson self-assigned this Jan 19, 2024
medplumbot added a commit that referenced this issue Jan 21, 2024
Fixes #3753 - root constraint validation (#3779)
Fixes #3614 - configurable agent log level (#3781)
Fixed validateDOMNesting warning (#3780)
Fixes #3775 - AsyncAutocomplete call onChange on remove (#3777)
Dependency upgrades (#3774)
Remove notice to contact `info@medplum.com` to enable open patient registration (#3776)
Move logger from server to core (#3773)
Create a task demo app (#3555)
Add docs for setting up CORS when self-hosting (#3752)
Export NotesDisplay from @medplum/react (#3759)
Fixes #3751 - restore AsyncAutocomplete props (#3758)
Add CodeSystem validate-code operation (#3705)
Update provider directory docs to administration section (#3747)
Avoid error on SearchPage while schema is being requested (#3757)
Fixes #3755 - allow embedding PDFs on external domains (#3756)
Fixes #3653 - Agent handle DICOM C-STORE (#3736)
ci(madge): add `madge` job for PRs against `medplum/test-actions` (#3745)
Handle websocket max payload exceeded (#3750)
Implement CodeSystem lookup operation (#3702)
Require super admin for CodeSystem import (#3739)
Add OTel documentation (#3738)
Better error on unique constraint violation (#3743)
Dependency upgrades (#3744)
feat(examples): add live chat example (#3713)
Move response utils to separate file (#3742)
Fix wrapping CodeSystem import handler (#3741)
Add lookup table to index CodeSystem codings (#3731)
github-merge-queue bot pushed a commit that referenced this issue Jan 21, 2024
Fixes #3753 - root constraint validation (#3779)
Fixes #3614 - configurable agent log level (#3781)
Fixed validateDOMNesting warning (#3780)
Fixes #3775 - AsyncAutocomplete call onChange on remove (#3777)
Dependency upgrades (#3774)
Remove notice to contact `info@medplum.com` to enable open patient registration (#3776)
Move logger from server to core (#3773)
Create a task demo app (#3555)
Add docs for setting up CORS when self-hosting (#3752)
Export NotesDisplay from @medplum/react (#3759)
Fixes #3751 - restore AsyncAutocomplete props (#3758)
Add CodeSystem validate-code operation (#3705)
Update provider directory docs to administration section (#3747)
Avoid error on SearchPage while schema is being requested (#3757)
Fixes #3755 - allow embedding PDFs on external domains (#3756)
Fixes #3653 - Agent handle DICOM C-STORE (#3736)
ci(madge): add `madge` job for PRs against `medplum/test-actions` (#3745)
Handle websocket max payload exceeded (#3750)
Implement CodeSystem lookup operation (#3702)
Require super admin for CodeSystem import (#3739)
Add OTel documentation (#3738)
Better error on unique constraint violation (#3743)
Dependency upgrades (#3744)
feat(examples): add live chat example (#3713)
Move response utils to separate file (#3742)
Fix wrapping CodeSystem import handler (#3741)
Add lookup table to index CodeSystem codings (#3731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react Features, fixes and enhancements to react component library
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

3 participants