Fixes #3751 - restore AsyncAutocomplete props #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
reshmakh
added
the
react
mattwiller
approved these changes
Jan 19, 2024
medplumbot
added a commit
that referenced
this pull request
Jan 21, 2024
Fixes #3753 - root constraint validation (#3779) Fixes #3614 - configurable agent log level (#3781) Fixed validateDOMNesting warning (#3780) Fixes #3775 - AsyncAutocomplete call onChange on remove (#3777) Dependency upgrades (#3774) Remove notice to contact `info@medplum.com` to enable open patient registration (#3776) Move logger from server to core (#3773) Create a task demo app (#3555) Add docs for setting up CORS when self-hosting (#3752) Export NotesDisplay from @medplum/react (#3759) Fixes #3751 - restore AsyncAutocomplete props (#3758) Add CodeSystem validate-code operation (#3705) Update provider directory docs to administration section (#3747) Avoid error on SearchPage while schema is being requested (#3757) Fixes #3755 - allow embedding PDFs on external domains (#3756) Fixes #3653 - Agent handle DICOM C-STORE (#3736) ci(madge): add `madge` job for PRs against `medplum/test-actions` (#3745) Handle websocket max payload exceeded (#3750) Implement CodeSystem lookup operation (#3702) Require super admin for CodeSystem import (#3739) Add OTel documentation (#3738) Better error on unique constraint violation (#3743) Dependency upgrades (#3744) feat(examples): add live chat example (#3713) Move response utils to separate file (#3742) Fix wrapping CodeSystem import handler (#3741) Add lookup table to index CodeSystem codings (#3731)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2024
Fixes #3753 - root constraint validation (#3779) Fixes #3614 - configurable agent log level (#3781) Fixed validateDOMNesting warning (#3780) Fixes #3775 - AsyncAutocomplete call onChange on remove (#3777) Dependency upgrades (#3774) Remove notice to contact `info@medplum.com` to enable open patient registration (#3776) Move logger from server to core (#3773) Create a task demo app (#3555) Add docs for setting up CORS when self-hosting (#3752) Export NotesDisplay from @medplum/react (#3759) Fixes #3751 - restore AsyncAutocomplete props (#3758) Add CodeSystem validate-code operation (#3705) Update provider directory docs to administration section (#3747) Avoid error on SearchPage while schema is being requested (#3757) Fixes #3755 - allow embedding PDFs on external domains (#3756) Fixes #3653 - Agent handle DICOM C-STORE (#3736) ci(madge): add `madge` job for PRs against `medplum/test-actions` (#3745) Handle websocket max payload exceeded (#3750) Implement CodeSystem lookup operation (#3702) Require super admin for CodeSystem import (#3739) Add OTel documentation (#3738) Better error on unique constraint violation (#3743) Dependency upgrades (#3744) feat(examples): add live chat example (#3713) Move response utils to separate file (#3742) Fix wrapping CodeSystem import handler (#3741) Add lookup table to index CodeSystem codings (#3731)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3751
Thanks @dillonstreator for being an early adopter of Medplum 3.0 🙏
In Medplum 2.x / Mantine 6, we were heavy users of the Mantine
<MultiSelect>component. In Mantine 6,<MultiSelect>was highly customizable, and we used it to the fullest extent.In Mantine 7, the philosophy of
<MultiSelect>changed significantly. It is no longer customizable. Instead, it is quite opinionated, and no longer servers our needs.Instead, the Mantine 7 recommendation is to use the lower level
<ComboBox>component, which exposes all of the low level guts of a combobox / autocomplete system.As part of that migration, a few features were lost that we didn't even know people were using.
The main bug here was that
AsyncAutocompletePropsstill extendedMultiSelectProps, when it should have extendedComboBoxProps. That gave a false sense of confidence that we still supported all of theMultiSelectfeatures.