Create a task demo app #3555

ksmith94 · 2023-12-15T17:09:22Z

This will create a demo app based around the task workflow, including creating, editing, and deleting tasks, as well as bots based around common task-related workflows.

vercel · 2023-12-15T17:09:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments

Name	Status	Preview	Updated (UTC)
medplum-app	⬜️ Ignored (Inspect)	Visit Preview	Jan 19, 2024 10:46pm
medplum-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jan 19, 2024 10:46pm
medplum-www	⬜️ Ignored (Inspect)	Visit Preview	Jan 19, 2024 10:46pm

sweep-ai · 2023-12-15T17:10:27Z

Apply Sweep Rules to your PR?

Apply: All new business logic should have corresponding unit tests.
Apply: Refactor large functions to be more modular.
Apply: Add docstrings to all functions and file headers.

examples/medplum-task-example-app/bots/src/create-review-report-task.ts

examples/medplum-task-example-app/bots/src/create-review-report-task.test.ts

examples/medplum-task-example-app/bots/src/create-respond-to-message-task.ts

examples/medplum-task-example-app/app/src/pages/TaskPage.tsx

examples/medplum-task-example-app/app/README.md

examples/medplum-task-example-app/app/src/App.tsx

examples/medplum-task-example-app/app/src/components/CreateTaskModal.tsx

examples/medplum-task-example-app/app/src/pages/PatientPage.tsx

examples/medplum-task-example-app/app/src/pages/ResourcePage.tsx

examples/medplum-task-example-app/app/src/pages/SignInPage.tsx

examples/medplum-task-example-app/bots/medplum.config.json

examples/medplum-task-example-app/bots/src/communication-data.ts

examples/medplum-task-example-app/app/README.md

examples/medplum-task-example-app/app/src/App.tsx

examples/medplum-task-example-app/app/src/components/task-actions/AddDueDate.tsx

examples/medplum-task-example-app/app/src/components/task-actions/ClaimTask.tsx

examples/medplum-task-example-app/app/src/components/task-actions/UpdateBusinessStatus.tsx

examples/medplum-task-example-app/app/src/components/PatientHistory.tsx

examples/medplum-task-example-app/bots/src/create-respond-to-message-task.test.ts

examples/medplum-task-example-app/data/respond-to-message-data.json

examples/medplum-task-example-app/app/src/components/task-actions/AddDueDate.tsx

examples/medplum-task-example-app/app/src/components/task-actions/AssignRole.tsx

examples/medplum-task-example-app/app/src/pages/NotesPage.tsx

github-actions · 2024-01-09T16:37:07Z

✅ prettier errors have been resolved. Thank you.

^{#0aad2f1c55dcbcb1c9147bb684a1c0bca2d9d95f}

examples/medplum-task-demo/src/components/patient-chart/Allergies.tsx

examples/medplum-task-demo/src/pages/LandingPage.tsx

examples/medplum-task-demo/src/pages/TaskPage.tsx

examples/medplum-task-demo/src/pages/SignInPage.tsx

examples/medplum-task-demo/src/bots/core/src/create-respond-to-message-task.test.ts

examples/medplum-task-demo/src/bots/.gitignore

examples/medplum-task-demo/src/App.tsx

examples/medplum-task-demo/medplum-task-demo-screenshot.png

examples/medplum-task-demo/README.md

github-actions · 2024-01-12T00:05:29Z

	Messages
📖	@medplum/core: 153.1 kB
📖	@medplum/react: 336.9 kB

Generated by 🚫 dangerJS against 2e942fe

rahul1

Ready for review

examples/medplum-demo-bots/src/health-gorilla/receive-from-health-gorilla.ts

Create and deploy bots and create message data Edit bots based on feedback Make edits based on review Update clinical profile and break out role queues for specific roles Update file structure and make changes based on review Update search pages for task specific tabs Create page and route to upload data and remove task specific search page Remove Error Boundary to reduce flicker Update display of Task title Delete unused queue pages Add task actions back to task page Update folder structure with data subdirs and get field and filters working on search controls Update business status value set and add dependency to patient chart Update readme Reverting root package.json changes Fixing package-lock.json Fix prettier Upgrade Task Demo to use `RouteProvider` Simplify role loading to prevent links flickering Clean up folder structure Implement Upload pages Update tab handling logic for search page Minor copy change Use - Use DocumentReference instead of Media (#3698) - Attach PDF to DiagnosticReport.presentedForm Support a Linux Agent artifact on the publish GitHub Actions. Fixes 3699 (#3700) * Rename Agent installer script to reference win64 * Add linux agent artifact and publishing workflow Update copy and add practitioner roles value set Remove unnecessary current tab state Revert "Support a Linux Agent artifact on the publish GitHub Actions. Fixes 3699 (#3700)" This reverts commit 165fabb. Revert "- Use DocumentReference instead of Media (#3698)" This reverts commit 1a8c561. Remove unused RoleQueue page Fixing package-lock?

.github/workflows/publish.yml

scripts/build-agent-installer-linux.sh

scripts/build-agent-installer-win64.sh

examples/medplum-task-demo/src/bots/example/communication-data.ts

examples/medplum-task-demo/src/pages/TaskPage.tsx

rahul1 · 2024-01-18T17:39:12Z

examples/medplum-task-demo/src/pages/ResourcePage.tsx

+
+  const tab = window.location.pathname.split('/').pop();
+  const currentTab = tab && tabs.map((t) => t.toLowerCase()).includes(tab) ? tab : tabs[0].toLowerCase();
+  console.log('Current tab', tab);


Delete this

codyebberson

Overall lgtm, thanks @ksmith94 👍

Nothing major, just some topics that I think we should align on for example apps, as we want these to exemplify Medplum best practices:

I'm tempted to remove the dependabot.yml files from all examples to reduce noise
We should align on ESBuild vs tsc for bots without imports, again to reduce noise
There are a bunch of checks for if (!task.id) - I assume those were mostly done to satisfy the TypeScript compiler, when you can safely assume that task.id is populated
Let's remove all debugging console.log() calls

General comments, out of scope for this PR:

Quite a bit of duplicate code for notifications.show() - we have this same problem in the main packages/app. I wonder if we should align on 2-3 standard notifications in packages/react for these common cases to reduce boilerplate

Again, overall, really great work. Thanks @ksmith94

codyebberson · 2024-01-18T19:09:30Z

examples/medplum-task-demo/esbuild-script.mjs

I don't think we need ESBuild here, vs just using tsc? Let's discuss offline w/ @rahul1

I'm tempted to remove the dependabot.yml files from all examples to reduce noise

I'm fine either way. Since we are syncing examples to external repos, I wasn't sure if it was required for that case. But of the root dependabot is handling this, we should be ok

There are a bunch of checks for if (!task.id) - I assume those were mostly done to satisfy the TypeScript compiler, when you can safely assume that task.id is populated

Is the recommended solution casting task.id as string?

Is the recommended solution casting task.id as string?

Yes I think that should work!

Thanks @codyebberson! I've addressed all the comments and changed (!task.id) checks to cast them as task.id as string in all the instances it uses them. I also updated all the modals to use useDisclosure.

examples/medplum-task-demo/src/App.tsx

examples/medplum-task-demo/src/components/actions/AddDueDate.tsx

examples/medplum-task-demo/src/components/actions/AddNote.tsx

examples/medplum-task-demo/src/pages/NotesPage.tsx

examples/medplum-task-demo/src/pages/ResourcePage.tsx

examples/medplum-task-demo/src/components/actions/AssignRole.tsx

examples/medplum-task-demo/src/components/actions/UpdateBusinessStatus.tsx

examples/medplum-task-demo/src/pages/SearchPage.tsx

examples/medplum-task-demo/src/pages/TaskPage.tsx

rahul1

Fix build errors, then approved!

sonarcloud · 2024-01-19T22:52:59Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Fixes #3753 - root constraint validation (#3779) Fixes #3614 - configurable agent log level (#3781) Fixed validateDOMNesting warning (#3780) Fixes #3775 - AsyncAutocomplete call onChange on remove (#3777) Dependency upgrades (#3774) Remove notice to contact `info@medplum.com` to enable open patient registration (#3776) Move logger from server to core (#3773) Create a task demo app (#3555) Add docs for setting up CORS when self-hosting (#3752) Export NotesDisplay from @medplum/react (#3759) Fixes #3751 - restore AsyncAutocomplete props (#3758) Add CodeSystem validate-code operation (#3705) Update provider directory docs to administration section (#3747) Avoid error on SearchPage while schema is being requested (#3757) Fixes #3755 - allow embedding PDFs on external domains (#3756) Fixes #3653 - Agent handle DICOM C-STORE (#3736) ci(madge): add `madge` job for PRs against `medplum/test-actions` (#3745) Handle websocket max payload exceeded (#3750) Implement CodeSystem lookup operation (#3702) Require super admin for CodeSystem import (#3739) Add OTel documentation (#3738) Better error on unique constraint violation (#3743) Dependency upgrades (#3744) feat(examples): add live chat example (#3713) Move response utils to separate file (#3742) Fix wrapping CodeSystem import handler (#3741) Add lookup table to index CodeSystem codings (#3731)

ksmith94 self-assigned this Dec 15, 2023

rahul1 requested changes Dec 18, 2023

View reviewed changes

rahul1 reviewed Dec 19, 2023

View reviewed changes

rahul1 requested changes Jan 4, 2024

View reviewed changes

rahul1 reviewed Jan 4, 2024

View reviewed changes

ksmith94 force-pushed the kevin-task-demo-app branch from 247c826 to 2bd9b78 Compare January 9, 2024 16:35

rahul1 reviewed Jan 11, 2024

View reviewed changes

rahul1 marked this pull request as ready for review January 12, 2024 08:45

rahul1 requested a review from a team as a code owner January 12, 2024 08:45

rahul1 reviewed Jan 12, 2024

View reviewed changes

rahul1 reviewed Jan 17, 2024

View reviewed changes

examples/medplum-demo-bots/src/health-gorilla/receive-from-health-gorilla.ts Outdated Show resolved Hide resolved

rahul1 force-pushed the kevin-task-demo-app branch 2 times, most recently from 7fa5fb1 to 9b716a0 Compare January 18, 2024 05:20

ksmith94 added 13 commits January 17, 2024 21:20

Copy hello-world and update new page and search page

2cb9540

Add notes and links to resources

00d582f

Make a tasks page with details and timeline

8e73217

Add the ability to add and view notes on a task

a2a808d

Add date picker to task actions and update routes

e5463a3

Add modals to task page

6cb4eb8

Add worklist of tasks assigned to user

9a500e0

Refactor patient chart and add notes to modal functions

853c6b5

Add functionality to modals and move handlers to new file

ff1237a

Add functionality to delete button

f66f830

Move modal questionnaires to separate folder

52b05ab

Add claim button and re-style task page

6e6c29d

Add tasks by role queue

626e281

ksmith94 and others added 10 commits January 17, 2024 21:20

Start to write tests for respond to message task bot

d8410de

Fix eslint errors

8c6a9d8

fix eslint errors

3c7cfbf

Fix additional eslint errors

d359570

Refactor task action modals

21e48f5

Get mono-repo working

69e6d7a

Refactor respond to message bot

5bae392

Fix buttons style and task re-rendering on update

5640cc0

Port to Mantine 7

d0e013e

rahul1 force-pushed the kevin-task-demo-app branch from 9b716a0 to d0e013e Compare January 18, 2024 06:01

rahul1 added 2 commits January 17, 2024 22:06

check out package-lock from main

8d38232

Added definitions to task-demo

3a3475b

rahul1 reviewed Jan 18, 2024

View reviewed changes

codyebberson reviewed Jan 18, 2024

View reviewed changes

Make changes based on review

d3f06fe

rahul1 approved these changes Jan 19, 2024

View reviewed changes

ksmith94 added 2 commits January 19, 2024 12:43

Remove unused import

776527d

Remove dependabot and esbuild

2e942fe

rahul1 approved these changes Jan 19, 2024

View reviewed changes

rahul1 enabled auto-merge January 19, 2024 22:48

rahul1 added this pull request to the merge queue Jan 19, 2024

Merged via the queue into main with commit 82e2427 Jan 19, 2024
20 checks passed

rahul1 deleted the kevin-task-demo-app branch January 19, 2024 23:03

medplumbot mentioned this pull request Jan 21, 2024

Release Version 3.0.1 #3782

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a task demo app #3555

Create a task demo app #3555

ksmith94 commented Dec 15, 2023

vercel bot commented Dec 15, 2023 •

edited

Loading

sweep-ai bot commented Dec 15, 2023

github-actions bot commented Jan 9, 2024 •

edited

Loading

github-actions bot commented Jan 12, 2024 •

edited

Loading

rahul1 left a comment

rahul1 Jan 18, 2024

codyebberson left a comment

codyebberson Jan 18, 2024

rahul1 Jan 19, 2024

rahul1 Jan 19, 2024

ThatOneBro Jan 19, 2024 •

edited

Loading

ksmith94 Jan 19, 2024

rahul1 left a comment

sonarcloud bot commented Jan 19, 2024

Create a task demo app #3555

Create a task demo app #3555

Conversation

ksmith94 commented Dec 15, 2023

vercel bot commented Dec 15, 2023 • edited Loading

sweep-ai bot commented Dec 15, 2023

Apply Sweep Rules to your PR?

github-actions bot commented Jan 9, 2024 • edited Loading

github-actions bot commented Jan 12, 2024 • edited Loading

rahul1 left a comment

Choose a reason for hiding this comment

rahul1 Jan 18, 2024

Choose a reason for hiding this comment

codyebberson left a comment

Choose a reason for hiding this comment

codyebberson Jan 18, 2024

Choose a reason for hiding this comment

rahul1 Jan 19, 2024

Choose a reason for hiding this comment

rahul1 Jan 19, 2024

Choose a reason for hiding this comment

ThatOneBro Jan 19, 2024 • edited Loading

Choose a reason for hiding this comment

ksmith94 Jan 19, 2024

Choose a reason for hiding this comment

rahul1 left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jan 19, 2024

Quality Gate passed

vercel bot commented Dec 15, 2023 •

edited

Loading

github-actions bot commented Jan 9, 2024 •

edited

Loading

github-actions bot commented Jan 12, 2024 •

edited

Loading

ThatOneBro Jan 19, 2024 •

edited

Loading