Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added restaurant-marketplace recipe #5

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

shahednasser
Copy link
Member

No description provided.

@shahednasser shahednasser merged commit cc672e6 into main Aug 29, 2024
1 check passed
@shahednasser shahednasser deleted the feat/restaurant-marketplace branch August 29, 2024 09:57
@juanzgc
Copy link

juanzgc commented Sep 5, 2024

Hi @shahednasser, could you possibly comment on deleting a Driver or Restaurant Admin.

Potentially, if I'm not mistaken, we'd have to delete both the driver and the related auth as well. I think it would be worth documenting this within the recipe because it could potentially be a security vulnerability if we only delete the driver and continue to maintain the auth id related to that driver. 😇

@shahednasser
Copy link
Member Author

Hi @juanzgc thank you for the feedback! I talked with the team and we're looking into the best way to resolve this. If it makes sense, will definitely add a section in the recipe about it

@juanzgc
Copy link

juanzgc commented Sep 6, 2024

Thanks @shahednasser, and lastly the recipes include authenticate(["restaurant", "admin"]) in the examples however admin should actually be changed to user since the actor type of the admin is user.

For example when you run:

npx medusa user -e admin@email.com -p supersecret

The actor type that seems to be used is user instead of admin.

@shahednasser
Copy link
Member Author

Nice catch 😅 will update it 👍🏻

@juanzgc
Copy link

juanzgc commented Sep 6, 2024

Thanks! There's a few places across different recipes that we'll want to update

@shahednasser
Copy link
Member Author

@juanzgc I only found it in the restaurant recipe, can you point me to other recipes where this issue is there?

@juanzgc
Copy link

juanzgc commented Sep 6, 2024

@shahednasser
Copy link
Member Author

Ah got it, however, this is a general guide of how to use the authentication module, it's not necessarily tied to any specific actor type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants