Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/product types endpoints #2553

Closed

Conversation

edihasaj
Copy link

@edihasaj edihasaj commented Nov 5, 2022

@edihasaj edihasaj requested a review from a team as a code owner November 5, 2022 19:56
@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2022

⚠️ No Changeset found

Latest commit: 716081e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl
Copy link
Contributor

@edihasaj Thank you so much for this contribution. Listing product types has recently been introduced in #2552. Can I get you to rebase off of develop and remove that part of the PR?

@edihasaj
Copy link
Author

edihasaj commented Nov 13, 2022

@edihasaj Thank you so much for this contribution. Listing product types has recently been introduced in #2552. Can I get you to rebase off of develop and remove that part of the PR?

@olivermrbl, yes I've noticed before and I used that endpoint, just extended and added the missing pieces. I'll rebase again to develop so that we have up to date branch 😁.

I'll check it anyways, to see if there is a conflict or redundancy to remove ;)

@edihasaj edihasaj force-pushed the feat/product-types-endpoints branch 2 times, most recently from 9a8ba5d to 2d4bd7a Compare November 13, 2022 20:32
@edihasaj edihasaj force-pushed the feat/product-types-endpoints branch from 184eb66 to 716081e Compare May 14, 2023 07:31
@vercel
Copy link

vercel bot commented May 14, 2023

@edihasaj is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@edihasaj edihasaj closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants