-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa): Add expanded relations to customer service query #5123
Conversation
🦋 Changeset detectedLatest commit: 16a8c49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@pevey is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
Is there a date for when this will be merged? It is blocking us quite a bit since we want to introduce customer groups to our store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could I get you to add an integration test?
@fxmb – PR is good to go. Requested a test to ensure the functionality works as expected. You can expect it to be included in the coming release, provided the changes have been added before then. |
Was this included in the release? Couldnt find it in the list of fixes... |
Is there an expected date for the next release or a date when this will be included? Otherwise we will build a custom route but would like to avoid this... |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Hey, thanks for the PR! Since v2 brought a lot of architectural changes, we will be closing this PR since it no longer applies to our new setup. If you would still like to open this PR, please rebase with the v1 branch and re-request a review. |
This PR addresses #5091.
The relations in the expand parameter are now correctly passed in customerService query and returned by the route.
I will make a separate PR for proposed changes to the /store/auth endpoint so that you can decide to accept/reject them independently.