Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): Add expanded relations to customer service query #5123

Closed
wants to merge 7 commits into from

Conversation

pevey
Copy link
Contributor

@pevey pevey commented Sep 18, 2023

This PR addresses #5091.

The relations in the expand parameter are now correctly passed in customerService query and returned by the route.

I will make a separate PR for proposed changes to the /store/auth endpoint so that you can decide to accept/reject them independently.

@pevey pevey requested a review from a team as a code owner September 18, 2023 19:28
@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

🦋 Changeset detected

Latest commit: 16a8c49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 18, 2023

@pevey is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@fxmb
Copy link

fxmb commented Sep 26, 2023

Is there a date for when this will be merged? It is blocking us quite a bit since we want to introduce customer groups to our store

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could I get you to add an integration test?

@olivermrbl
Copy link
Contributor

@fxmb – PR is good to go. Requested a test to ensure the functionality works as expected. You can expect it to be included in the coming release, provided the changes have been added before then.

@fxmb
Copy link

fxmb commented Oct 25, 2023

Was this included in the release? Couldnt find it in the list of fixes...

@fxmb
Copy link

fxmb commented Oct 26, 2023

Is there an expected date for the next release or a date when this will be included? Otherwise we will build a custom route but would like to avoid this...

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-ui 🔄 Building (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 8:45am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 8:45am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 8:45am

@olivermrbl olivermrbl changed the title Add expanded relations to customer service query feat(medusa): Add expanded relations to customer service query Nov 2, 2023
@riqwan
Copy link
Contributor

riqwan commented Jul 5, 2024

Hey, thanks for the PR! Since v2 brought a lot of architectural changes, we will be closing this PR since it no longer applies to our new setup.

If you would still like to open this PR, please rebase with the v1 branch and re-request a review.

@riqwan riqwan closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants