-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(admin-ui): sort supported languages alphabetically #5479
fix(admin-ui): sort supported languages alphabetically #5479
Conversation
🦋 Changeset detectedLatest commit: fc63e42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
Is this issue still open, I would like to contribute. |
@its-kunal what would you like to add? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What?
Added sorting to the
supportedLanguages
array inpackages/admin-ui/ui/src/i18n/index.ts
. This makes sure the languages in the dropdown are sorted alphabetically.Why?
As we're supporting more languages in the admin UI, this list was getting messy.
How?
By using
sort()
andlocaleCompare()
on array declaration.Testing
Go to Medusa Admin locally, login and navigate to Settings > Personal information to test the language dropdown.