feat(pricing, types, utils): Soft delete pricing entities #5858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4234fa3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
pKorsholm
changed the title
adrien2p
requested changes
Dec 15, 2023
Comment on lines
+1285
to
+1287
| * import { | ||
| * initialize as initializePricingModule, | ||
| * } from "@medusajs/pricing" |
There was a problem hiding this comment.
comment: At some point we will have to start using the medusa app like:
const { modules } = await MedusaApp({
modulesConfig,
servicesConfig: joinerConfig,
injectedDependencies,
})not now but just to say
riqwan
approved these changes
Dec 15, 2023
|
@adrien2p can I get you to give this another review? |
adrien2p
approved these changes
Jan 2, 2024
What are next steps for this one? |
This was referenced Jan 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
softDeleteMoneyAmountpriceSetMoneyAmountandpriceRulerestoreSoftDeletedMoneyAmount