Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa-payment-stripe): change webhook environment variables to plugin options #6034

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

shahednasser
Copy link
Member

Changes the STRIPE_WEBHOOK_DELAY and STRIPE_WEBHOOK_RETRIES environment variables to plugin options.

@shahednasser shahednasser requested a review from a team as a code owner January 9, 2024 11:09
Copy link

changeset-bot bot commented Jan 9, 2024

🦋 Changeset detected

Latest commit: 10ead1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
medusa-payment-stripe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 11:39am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2024 11:39am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2024 11:39am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2024 11:39am

@olivermrbl
Copy link
Contributor

/snapshot-this

Copy link
Contributor

github-actions bot commented Jan 9, 2024

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin@7.1.10-snapshot-20240109120126
yarn add @medusajs/admin-ui@2.1.11-snapshot-20240109120126
yarn add @medusajs/core-flows@0.0.4-snapshot-20240109120126
yarn add create-medusa-app@1.2.6-snapshot-20240109120126
yarn add @medusajs/link-modules@0.2.6-snapshot-20240109120126
yarn add @medusajs/medusa@1.19.1-snapshot-20240109120126
yarn add medusa-core-utils@1.2.1-snapshot-20240109120126
yarn add medusa-fulfillment-manual@1.1.39-snapshot-20240109120126
yarn add medusa-fulfillment-webshipper@1.4.2-snapshot-20240109120126
yarn add medusa-interfaces@1.3.8-snapshot-20240109120126
yarn add @medusajs/medusa-js@6.1.5-snapshot-20240109120126
yarn add medusa-payment-adyen@1.1.45-snapshot-20240109120126
yarn add medusa-payment-stripe@6.0.7-snapshot-20240109120126
yarn add medusa-react@9.0.13-snapshot-20240109120126
yarn add medusa-test-utils@1.1.41-snapshot-20240109120126
yarn add @medusajs/modules-sdk@1.12.6-snapshot-20240109120126
yarn add @medusajs/orchestration@0.5.2-snapshot-20240109120126
yarn add @medusajs/pricing@0.1.7-snapshot-20240109120126
yarn add @medusajs/product@0.3.7-snapshot-20240109120126
yarn add @medusajs/types@1.11.10-snapshot-20240109120126
yarn add @medusajs/utils@1.11.3-snapshot-20240109120126
yarn add @medusajs/workflows-sdk@0.1.1-snapshot-20240109120126

Latest commit: 3eee2bd

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm

@olivermrbl olivermrbl merged commit 125879a into develop Jan 9, 2024
16 checks passed
@olivermrbl olivermrbl deleted the fix/stripe-options branch January 9, 2024 12:21
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
pKorsholm pushed a commit that referenced this pull request Jan 10, 2024
…lugin options (#6034)

* fix(medusa-payment-stripe): change webhook environment variables to plugin options

* access options through service
pKorsholm pushed a commit that referenced this pull request Jan 10, 2024
…lugin options (#6034)

* fix(medusa-payment-stripe): change webhook environment variables to plugin options

* access options through service
pKorsholm pushed a commit that referenced this pull request Jan 10, 2024
…lugin options (#6034)

* fix(medusa-payment-stripe): change webhook environment variables to plugin options

* access options through service
pKorsholm pushed a commit that referenced this pull request Jan 10, 2024
…lugin options (#6034)

* fix(medusa-payment-stripe): change webhook environment variables to plugin options

* access options through service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants