Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Payment module package setup #6059

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Jan 11, 2024

What

  • package skeleton for Payment module

Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: 85e4e6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/modules-sdk Patch
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 10:51am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 10:51am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 10:51am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 10:51am

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏎️

import * as defaultRepositories from "@repositories"
import * as defaultServices from "@services"

export default async ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: We could use a util for this, I reckon. In most cases, the loader looks the same. Only difference is what services (from @services) and repos (from @repositories`) are registered in the container.

@olivermrbl olivermrbl merged commit 8472460 into develop Jan 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants