Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(utils): Update base repository to infer primary keys and support composite #6062

Merged
merged 6 commits into from
Jan 14, 2024

Conversation

adrien2p
Copy link
Member

What
Add support for composite keys support in the base module repository class

@adrien2p adrien2p marked this pull request as ready for review January 11, 2024 15:18
@adrien2p adrien2p requested a review from a team as a code owner January 11, 2024 15:18
Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: bf281e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@medusajs/authentication Patch
@medusajs/pricing Patch
@medusajs/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 11:55am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2024 11:55am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2024 11:55am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2024 11:55am

@adrien2p
Copy link
Member Author

@olivermrbl can we merge this ?

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion. Take it or leave it :)

Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olivermrbl olivermrbl merged commit 72bc522 into develop Jan 14, 2024
16 checks passed
@olivermrbl olivermrbl deleted the chore/utils-repository-base-composite-support branch January 14, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants