Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utils,types): campaigns and campaign budgets + services CRUD #6063

Merged
merged 25 commits into from
Jan 12, 2024
Merged

feat(utils,types): campaigns and campaign budgets + services CRUD #6063

merged 25 commits into from
Jan 12, 2024

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jan 11, 2024 •
edited
Loading

Awaiting #6050

what:

  • adds campaigns and campaign budget services / repo / model
  • adds campaigns CRUD through entry point service

RESOLVES CORE-1635
RESOLVES CORE-1636

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: cef08a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/types Patch
@medusajs/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2024 1:02pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2024 1:02pm
medusa-dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2024 1:02pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 12, 2024 1:02pm

@riqwan riqwan changed the title chore: campaigns and campaign budgets + services CRUD feat(utils,types): campaigns and campaign budgets + services CRUD Jan 11, 2024
@riqwan riqwan marked this pull request as ready for review January 11, 2024 16:52
@riqwan riqwan requested a review from a team as a code owner January 11, 2024 16:52
olivermrbl
olivermrbl approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks really good ... I have a couple of comments to address, but nothing major

packages/types/src/promotion/service.ts Show resolved Hide resolved
packages/types/src/promotion/common/campaign.ts Outdated Show resolved Hide resolved
packages/types/src/promotion/service.ts Show resolved Hide resolved
packages/types/src/promotion/service.ts Show resolved Hide resolved
packages/promotion/src/services/promotion-module.ts Show resolved Hide resolved
packages/promotion/src/services/campaign-budget.ts Outdated Show resolved Hide resolved
packages/promotion/src/models/campaign.ts Outdated Show resolved Hide resolved
packages/promotion/src/models/campaign.ts Outdated Show resolved Hide resolved
packages/promotion/src/models/campaign-budget.ts Outdated Show resolved Hide resolved
pKorsholm
pKorsholm reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@pKorsholm pKorsholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a couple of suggestions but I think it generally looks good! 😄

packages/promotion/src/models/campaign-budget.ts Outdated Show resolved Hide resolved
packages/promotion/src/models/campaign.ts Outdated Show resolved Hide resolved
packages/promotion/src/models/campaign.ts Outdated Show resolved Hide resolved
packages/promotion/src/models/campaign.ts Outdated Show resolved Hide resolved
packages/promotion/src/models/campaign.ts Outdated Show resolved Hide resolved
packages/promotion/src/models/campaign-budget.ts Show resolved Hide resolved
packages/types/src/promotion/common/campaign-budget.ts Show resolved Hide resolved
@riqwan @pKorsholm
Apply suggestions from code review
d5695dc 
Co-authored-by: Philip Korsholm <88927411+pKorsholm@users.noreply.github.com>
@riqwan riqwan requested a review from pKorsholm January 12, 2024 07:38
@riqwan
Copy link
Contributor Author

riqwan commented Jan 12, 2024

Nice review @pKorsholm 💪🏻, made the changes!

@riqwan riqwan changed the base branch from feat/compute-actions to develop January 12, 2024 13:01
@riqwan riqwan merged commit fade8ea into develop Jan 12, 2024
16 checks passed
@riqwan riqwan deleted the feat/campaigns branch January 12, 2024 13:14
This was referenced Jan 12, 2024
Merged
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p Awaiting requested review from adrien2p

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

@pKorsholm pKorsholm Awaiting requested review from pKorsholm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riqwan @olivermrbl @pKorsholm