Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Payment module interface #6092

Merged
merged 41 commits into from
Jan 18, 2024
Merged

feat: Payment module interface #6092

merged 41 commits into from
Jan 18, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Jan 15, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 16945f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2024 3:07pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 3:07pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 3:07pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2024 3:07pm

@fPolic fPolic marked this pull request as ready for review January 16, 2024 09:03
@fPolic fPolic requested a review from a team as a code owner January 16, 2024 09:03
adrien2p
adrien2p requested changes Jan 16, 2024
View reviewed changes
packages/payment/src/models/payment.ts Outdated Show resolved Hide resolved
packages/types/src/payment/mutations.ts Show resolved Hide resolved
packages/types/src/payment/mutations.ts Show resolved Hide resolved
packages/types/src/payment/service.ts Outdated Show resolved Hide resolved
packages/types/src/payment/service.ts Show resolved Hide resolved
packages/types/src/payment/service.ts Show resolved Hide resolved
packages/types/src/payment/service.ts Show resolved Hide resolved
olivermrbl
olivermrbl approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can address the interface proposals in follow up PRs as we get closer to the implementation specifics.

adrien2p
adrien2p approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright to do the rest in a follow up pr we just need to remember

packages/types/src/payment/mutations.ts Outdated Show resolved Hide resolved
@fPolic fPolic changed the base branch from feat/payment-module-models to develop January 18, 2024 15:00
@fPolic fPolic requested a review from a team as a code owner January 18, 2024 15:00
@fPolic fPolic merged commit 6941627 into develop Jan 18, 2024
16 checks passed
@github-actions github-actions bot mentioned this pull request Jan 18, 2024
Merged
@fPolic fPolic mentioned this pull request Jan 18, 2024
Closed
This was referenced Jan 22, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@adrien2p adrien2p adrien2p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fPolic @adrien2p @olivermrbl